Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning when the chunk_number is not needed #883

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Conversation

dachengx
Copy link
Collaborator

What is the problem / what does the code in this PR do

Just add a warning.

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).

@dachengx dachengx marked this pull request as ready for review August 26, 2024 21:33
@dachengx dachengx merged commit 8e189a7 into master Aug 26, 2024
8 checks passed
@dachengx dachengx deleted the check_chunk_number branch August 26, 2024 21:33
@coveralls
Copy link

Coverage Status

coverage: 91.307% (+0.02%) from 91.285%
when pulling c09da1e on check_chunk_number
into 1e42cda on master.

@dachengx dachengx changed the title Show waring when the chunk_number is not needed Show warning when the chunk_number is not needed Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants