Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use run_id_output sorting final_result in multi_run #885

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

dachengx
Copy link
Collaborator

What is the problem / what does the code in this PR do

The deleted if statement is not really needed because run_id_output is always generated no matter add_run_id_field is True or False.

Close: #783

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).

@coveralls
Copy link

coveralls commented Aug 29, 2024

Coverage Status

coverage: 90.81% (-0.005%) from 90.815%
when pulling ba1d747 on simplify_add_run_id_field
into 04aa884 on master.

@dachengx dachengx marked this pull request as ready for review August 29, 2024 21:36
@dachengx dachengx merged commit 5192fce into master Aug 30, 2024
8 checks passed
@dachengx dachengx deleted the simplify_add_run_id_field branch August 30, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requesting an empty run as part of a multi_run call with add_run_id_field=False fails
2 participants