Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select targeted software frontend in a clever way #893

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

dachengx
Copy link
Collaborator

What is the problem / what does the code in this PR do

Copy the codes from strax.Context.copy_to_frontend to strax.Context._get_target_sf and strax.Context._check_merge_per_chunk_storage_kwargs and use then in strax.Context.merge_per_chunk_storage.

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).

@coveralls
Copy link

coveralls commented Sep 24, 2024

Coverage Status

coverage: 90.342% (+0.02%) from 90.327%
when pulling 9791b43 on better_merge_per_chunk_storage
into 0696ef5 on master.

dachengx added a commit to XENONnT/straxen that referenced this pull request Sep 24, 2024
@dachengx dachengx marked this pull request as ready for review September 24, 2024 13:58
@dachengx dachengx requested a review from yuema137 September 24, 2024 14:24
@dachengx dachengx merged commit 4b823ac into master Sep 24, 2024
8 checks passed
@dachengx dachengx deleted the better_merge_per_chunk_storage branch September 24, 2024 14:37
dachengx added a commit to XENONnT/straxen that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants