Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel usage of chunk_number if loading the whole dependency #894

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

dachengx
Copy link
Collaborator

What is the problem / what does the code in this PR do

To make the lineage unchanged after merging per-chunk storage, we need to set chunk_number to None to keep lineage hash the same as non-per-chunk storage.

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).

@coveralls
Copy link

coveralls commented Sep 24, 2024

Coverage Status

coverage: 90.331% (-0.01%) from 90.342%
when pulling 805adcb on cancel_chunk_number
into 4b823ac on master.

@dachengx dachengx marked this pull request as ready for review September 24, 2024 22:09
@dachengx dachengx merged commit ef2861e into master Sep 25, 2024
8 checks passed
@dachengx dachengx deleted the cancel_chunk_number branch September 25, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants