-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove max_downsample_factor_waveform_start
, simplify the saving of data_start
#910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes unknown |
dachengx
changed the title
Remove
Remove Oct 16, 2024
store_waveform_start
, simplify the saving of data_start
max_downsample_factor_waveform_start
, simplify the saving of data_start
dachengx
changed the title
Remove
Remove Oct 16, 2024
max_downsample_factor_waveform_start
, simplify the saving of data_start
max_downsample_factor_waveform_start
, simplify the saving of data_start
The incompatible to straxen, shown by the failure of autotests, is because of the change from |
dachengx
added a commit
to XENONnT/straxen
that referenced
this pull request
Oct 16, 2024
dachengx
added a commit
to XENONnT/straxen
that referenced
this pull request
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem / what does the code in this PR do
max_downsample_factor_waveform_start
is not strictly needed. We can use the following logic: ifstore_in_data_start
isFalse
, do not save thedata_start
.Also, change
digitize_top
tostore_data_top
,store_in_data_top
tostore_data_top
to unify the variable names.Can you briefly describe how it works?
Can you give a minimal working example (or illustrate with a figure)?
Please include the following if applicable:
Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).