Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove max_downsample_factor_waveform_start, simplify the saving of data_start #910

Merged
merged 9 commits into from
Oct 16, 2024

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Oct 16, 2024

What is the problem / what does the code in this PR do

max_downsample_factor_waveform_start is not strictly needed. We can use the following logic: if store_in_data_start is False, do not save the data_start.

Also, change digitize_top to store_data_top, store_in_data_top to store_data_top to unify the variable names.

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).

@dachengx dachengx requested a review from HenningSE October 16, 2024 04:34
@dachengx dachengx marked this pull request as ready for review October 16, 2024 04:34
@coveralls
Copy link

coveralls commented Oct 16, 2024

Coverage Status

Changes unknown
when pulling 0e14b54 on data_start_simplify
into ** on master**.

@dachengx dachengx changed the title Remove store_waveform_start, simplify the saving of data_start Remove max_downsample_factor_waveform_start , simplify the saving of data_start Oct 16, 2024
@dachengx dachengx changed the title Remove max_downsample_factor_waveform_start , simplify the saving of data_start Remove max_downsample_factor_waveform_start, simplify the saving of data_start Oct 16, 2024
@dachengx
Copy link
Collaborator Author

The incompatible to straxen, shown by the failure of autotests, is because of the change from digitize_top to store_data_top .

@dachengx dachengx merged commit a59bd07 into master Oct 16, 2024
5 of 8 checks passed
@dachengx dachengx deleted the data_start_simplify branch October 16, 2024 15:00
dachengx added a commit to XENONnT/straxen that referenced this pull request Oct 16, 2024
dachengx added a commit to XENONnT/straxen that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants