Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make variables names more robust in peak_dtype #911

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

dachengx
Copy link
Collaborator

What is the problem / what does the code in this PR do

Change the logic in peak_dtype following the codes.

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).

@dachengx dachengx marked this pull request as ready for review October 16, 2024 16:38
@dachengx dachengx merged commit c509e69 into master Oct 16, 2024
7 of 8 checks passed
@dachengx dachengx deleted the save_data_start branch October 16, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant