Fixing store_data_start in recursive peak splitter calls and peaklet["length'] fix in store_downsampled_waveform #920
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem / what does the code in this PR do
This PR fixes some smaller problems related to the
data_start
handling in thepeaklets
building/ splitting.store_data_start
was not passed to recursive calls of the peak splitter. As a result somepeaklets
haddata_start
always set to 0.peaklet["length']
is used instore_downsampled_waveform
to select the part of the waveform that is stored indata_start
. If the waveform is downsampled,peaklet["length']
is overwritten. When savingdata_start
we need to take the initial length of the peaklet not the downsampled length.