Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move set_nan_defaults from straxen to strax #936

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Dec 16, 2024

What is the problem / what does the code in this PR do

Because a lot of packages are using it.

Preparing for XENONnT/straxen#1491.

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).

@coveralls
Copy link

Coverage Status

coverage: 89.274% (-0.05%) from 89.327%
when pulling b039415 on add_set_nan_defaults
into 574661b on master.

@dachengx dachengx marked this pull request as ready for review December 16, 2024 03:58
@dachengx dachengx merged commit 956031e into master Dec 16, 2024
8 checks passed
@dachengx dachengx deleted the add_set_nan_defaults branch December 16, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants