Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First convert to int then add float to keep precision #939

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Dec 18, 2024

Just a minor improvement.

If using the previous approach, the center_time will be first converted to float then int. But the large time might cause the numerical error.

Following #938

@coveralls
Copy link

coveralls commented Dec 18, 2024

Coverage Status

coverage: 89.181%. remained the same
when pulling 443064c on keep_precision
into 831c4ee on master.

@dachengx dachengx marked this pull request as ready for review December 18, 2024 19:52
@dachengx dachengx merged commit 16d71c0 into master Dec 18, 2024
8 checks passed
@dachengx dachengx deleted the keep_precision branch December 18, 2024 19:52
@dachengx dachengx changed the title First concert to int then add float to keep precision First convert to int then add float to keep precision Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants