Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate area_fraction_top, center_time and median_time at peaklet level #941

Merged
merged 14 commits into from
Dec 20, 2024

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Dec 19, 2024

What is the problem / what does the code in this PR do

Add area_fraction_top, center_time, and median_time to peak_dtype. They will be calculated by compute_properties.

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).

@dachengx dachengx changed the title Calculate area_fraction_top, peak_dtype and median_time at peaklet level Calculate area_fraction_top, center_time and median_time at peaklet level Dec 19, 2024
@dachengx dachengx changed the title Calculate area_fraction_top, center_time and median_time at peaklet level Calculate area_fraction_top, center_time and median_time at peaklet level Dec 19, 2024
@coveralls
Copy link

coveralls commented Dec 19, 2024

Coverage Status

coverage: 89.201% (+0.02%) from 89.181%
when pulling db8356c on add_center_time_median_peaks
into bfb947d on master.

@dachengx dachengx marked this pull request as ready for review December 19, 2024 03:00
@dachengx dachengx merged commit 2ed84f9 into master Dec 20, 2024
8 checks passed
@dachengx dachengx deleted the add_center_time_median_peaks branch December 20, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants