Delete input chunks after compute method to save memory #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dachengx
commented
Dec 23, 2024
| @@ -206,9 +206,9 @@ def split(self, t: ty.Union[int, None], allow_early_split=False): | |||
| """ | |||
| t = max(min(t, self.end), self.start) # type: ignore | |||
| if t == self.end: | |||
| data1, data2 = self.data, self.data[:0] | |||
| data1, data2 = self.data, self.data[:0].copy() | |||
There was a problem hiding this comment.
This is to prevent the reference build between data2 and self.data to make sure that the sys.getrefcount(data) is low enough.
dachengx
commented
Dec 23, 2024
| _kwargs["start"] = start | ||
| _kwargs["end"] = end | ||
| result = self.compute(**_kwargs) | ||
| del _kwargs |
There was a problem hiding this comment.
Delete _kwargs because it will keep a reference between _kwargs and kwargs[k].data.
dachengx
commented
Dec 23, 2024
| f"Reference count of input {k} is {n} " | ||
| "and should be 1. This is a memory leak." | ||
| ) | ||
| del kwargs[k].data |
There was a problem hiding this comment.
You might see AttributeError when calling kwargs[k] which is a strax.Chunk after this deletion. So do not delete if you really want to reuse kwargs[k], though this is very discouraged.
This was referenced Dec 24, 2024
dachengx
added a commit
that referenced
this pull request
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will lower the memory usage of
st.make(run_id, 'peaklets')of XENONnT by 1 / 6, if setclean_chunk_after_compute = True.Note: https://xe1t-wiki.lngs.infn.it/doku.php?id=xenon:xenonnt:straxen:optimize_outsource_resources#optimized_memory_usage