Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle multiple rename (delete) events in inotify buffer #172

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Properly handle multiple rename (delete) events in inotify buffer #172

merged 1 commit into from
Nov 28, 2022

Conversation

tsmaeder
Copy link
Contributor

Supposed to fix #171

Contributed on behalf of ST Microelectronics

Signed-off-by: Thomas Mäder [email protected]

@tsmaeder
Properly handle multiple rename (delete) events in inotify buffer
bda2cd8 
Contributed on behalf of ST Microelectronics

Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder
Copy link
Contributor Author

@julianmesa-gitkraken what's the protocol for getting PR's merged?

@julianmesa-gitkraken
Copy link
Contributor

@julianmesa-gitkraken what's the protocol for getting PR's merged?

I need to reproduce and test it, I will try to do it today

@tsmaeder
Copy link
Contributor Author

Fantastic, thanks.

@julianmesa-gitkraken julianmesa-gitkraken self-assigned this Nov 24, 2022
julianmesa-gitkraken
julianmesa-gitkraken approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@julianmesa-gitkraken julianmesa-gitkraken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After testing, I agree with the solution.
We are moving to trash and removeDirectory should be called when isDirectoryRemoval only.

@ianhattendorf ianhattendorf merged commit d88460b into Axosoft:master Nov 28, 2022
@ianhattendorf
Copy link
Contributor

Thanks!

@tsmaeder
Copy link
Contributor Author

@ianhattendorf can you give an ETA when a new release will go out?

@ianhattendorf
Copy link
Contributor

I'm planning on getting #170 and #173 in before pushing out a release. We should hopefully have time to wrap them up within the next week or two.

@tsmaeder
Copy link
Contributor Author

Thx, it's great to have an approximate ETA (and more fixes).

@tsmaeder tsmaeder mentioned this pull request Dec 9, 2022
Merged
1 task
erezmus added a commit to ARMmbed/nsfw that referenced this pull request Jan 5, 2023
@erezmus
add upstream fix for multiple rename (delete) events
daf3383 
see Axosoft#172
@erezmus erezmus mentioned this pull request Jan 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianmesa-gitkraken julianmesa-gitkraken julianmesa-gitkraken approved these changes

@ianhattendorf ianhattendorf Awaiting requested review from ianhattendorf

Assignees

@ianhattendorf ianhattendorf

@julianmesa-gitkraken julianmesa-gitkraken

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when deleting large number of files
3 participants
@tsmaeder @julianmesa-gitkraken @ianhattendorf