Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Proxy support in GitHubTokenService #931

Merged
merged 2 commits into from
Oct 15, 2024
Merged

feat: Proxy support in GitHubTokenService #931

merged 2 commits into from
Oct 15, 2024

Conversation

alfespa17
Copy link
Member

@alfespa17 alfespa17 commented Jun 7, 2024

Added support for proxy in the GitHubTokenService. The code now checks if a proxy host is set in system properties and if so, uses it to create the HttpClient. If no proxy host is specified, it falls back to the default settings. Additionally, log messages were introduced to aid in debugging.

Fix #902

Added support for proxy in the GitHubTokenService. The code now checks if a proxy host is set in system properties and if so, uses it to create the HttpClient. If no proxy host is specified, it falls back to the default settings. Additionally, log messages were introduced to aid in debugging.
Copy link

sonarqubecloud bot commented Jun 7, 2024

Copy link

@alfespa17 alfespa17 merged commit 383c2c6 into main Oct 15, 2024
6 checks passed
@alfespa17 alfespa17 deleted the proxy-vcs-github branch October 15, 2024 17:20
@alfespa17 alfespa17 changed the title Add proxy support to GitHubTokenService feat: Proxy support to GitHubTokenService Oct 15, 2024
@alfespa17 alfespa17 changed the title feat: Proxy support to GitHubTokenService feat: Proxy support in GitHubTokenService Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConnectTimeoutException When proxy is used
1 participant