Skip to content

Commit

Permalink
chore: Remove private kernel snapshot test (#5829)
Browse files Browse the repository at this point in the history
Follows the policy of "remove snapshots that don't provide useful info",
and deletes a test suite that not just generated snapshots, but also
depended on data generated from e2e tests, which meant that a change in
noir-protocol-circuits required a new e2e test run to regenerate
snapshots in a unit test of noir-protocol-circuit-types.
  • Loading branch information
spalladino authored Apr 18, 2024
1 parent c3dd039 commit 9434784
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 2,250 deletions.
32 changes: 0 additions & 32 deletions yarn-project/end-to-end/src/e2e_nested_contract.test.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
import { type AztecAddress, BatchCall, type DebugLogger, Fr, type PXE, type Wallet, toBigIntBE } from '@aztec/aztec.js';
import { getTestData, isGenerateTestDataEnabled } from '@aztec/foundation/testing';
import { ChildContract, ImportTestContract, ParentContract, TestContract } from '@aztec/noir-contracts.js';

import { writeFileSync } from 'fs';

import { setup } from './fixtures/utils.js';

describe('e2e_nested_contract', () => {
Expand Down Expand Up @@ -34,35 +31,6 @@ describe('e2e_nested_contract', () => {
.entry_point(childContract.address, childContract.methods.value.selector)
.send()
.wait();

if (isGenerateTestDataEnabled()) {
{
const privateKernelInputsInit = getTestData('private-kernel-inputs-init');
const nestedCallPrivateKernelInput = privateKernelInputsInit[0];
writeFileSync(
'../noir-protocol-circuits-types/src/fixtures/nested-call-private-kernel-init.hex',
nestedCallPrivateKernelInput.toBuffer().toString('hex'),
);
}

{
const privateKernelInputsInner = getTestData('private-kernel-inputs-inner');
const nestedCallPrivateKernelInput = privateKernelInputsInner[privateKernelInputsInner.length - 1];
writeFileSync(
'../noir-protocol-circuits-types/src/fixtures/nested-call-private-kernel-inner.hex',
nestedCallPrivateKernelInput.toBuffer().toString('hex'),
);
}

{
const privateKernelInputsOrdering = getTestData('private-kernel-inputs-ordering');
const nestedCallPrivateKernelInput = privateKernelInputsOrdering[0];
writeFileSync(
'../noir-protocol-circuits-types/src/fixtures/nested-call-private-kernel-ordering.hex',
nestedCallPrivateKernelInput.toBuffer().toString('hex'),
);
}
}
}, 100_000);

it('fails simulation if calling a function not allowed to be called externally', async () => {
Expand Down
Loading

0 comments on commit 9434784

Please sign in to comment.