Engineer can identify when the P2P module is synced with the rollup source #4
Assignees
Comments
ludamad
pushed a commit
that referenced
this issue
Jul 14, 2023
* Fix to bootstrap.sh after move into submodule (#1) * Updated bootstrap now that bberg may be a submodule, and now that cpp subdir exists * fix gitignore, wasnt properly ignoring cpp/build* * fix the barretenberg cpp formatting pre-commit hook now that barretenberg iss its own repo and may be a submodule * Contrived change. * Revert "Contrived change." This reverts commit ea18e58180f70a5e0f0a3419f4beba461d6917cb. * Revert "Revert "Contrived change."" This reverts commit 6ad33bccc4e5a1d76467a61b0d18d369fd32988e. * Introduce cpp to paths. * More cpp path. * Cl/mum merge (#4) * Initial merge. Still has conflicts. * Tidied up bigfield and biggroup * Builds. * Order constants. * Fix. * Make more tests pass. * Update circuit change detection stuff to be local to tests. * Include header. * Cleanup and settings. * Path updates. * Path updates. Co-authored-by: Rumata888 <[email protected]> Co-authored-by: David Banks <[email protected]> Co-authored-by: Rumata888 <[email protected]>
codygunton
pushed a commit
that referenced
this issue
Jan 23, 2024
* Fix to bootstrap.sh after move into submodule (#1) * Updated bootstrap now that bberg may be a submodule, and now that cpp subdir exists * fix gitignore, wasnt properly ignoring cpp/build* * fix the barretenberg cpp formatting pre-commit hook now that barretenberg iss its own repo and may be a submodule * Contrived change. * Revert "Contrived change." This reverts commit 68aff9c99c683956f417d069360ca36deb5e351c. * Revert "Revert "Contrived change."" This reverts commit 3eee2fdd5133490ae57fd2db94c645891e3e8fcf. * Introduce cpp to paths. * More cpp path. * Cl/mum merge (#4) * Initial merge. Still has conflicts. * Tidied up bigfield and biggroup * Builds. * Order constants. * Fix. * Make more tests pass. * Update circuit change detection stuff to be local to tests. * Include header. * Cleanup and settings. * Path updates. * Path updates. Co-authored-by: Rumata888 <[email protected]> Co-authored-by: David Banks <[email protected]> Co-authored-by: Rumata888 <[email protected]>
ludamad
added a commit
that referenced
this issue
Jun 6, 2024
Overview: If you are in a scenario where you have a failing call to check_circuit and wish to get more information out of it than just the gate index, you can use this feature to get a stack trace, see example below. Usage instructions: - On ubuntu (or our mainframe accounts) use `sudo apt-get install libdw-dev` to support trace printing - Use `cmake --preset clang16-dbg-fast-circuit-check-traces` and `cmake --build --preset clang16-dbg-fast-circuit-check-traces` to enable the backward-cpp dependency through the CHECK_CIRCUIT_STACKTRACES CMake variable. - Run any case where you have a failing check_circuit call, you will now have a stack trace illuminating where this constraint was added in code. Caveats: - This works best for code that is not overly generic, i.e. where just the sequence of function calls carries a lot of information. It is possible to tag extra data along with the stack trace, this can be done as a followup, please leave feedback if desired. - There are certain functions like `assert_equals` that can cause gates that occur _before_ them to fail. If this would be useful to automatically report, please leave feedback. Example: ``` [ RUN ] standard_circuit_constructor.test_check_circuit_broken Stack trace (most recent call last): #4 Source "_deps/gtest-src/googletest/src/gtest.cc", line 2845, in Run 2842: if (!Test::HasFatalFailure() && !Test::IsSkipped()) { 2843: // This doesn't throw as all user code that can throw are wrapped into 2844: // exception handling code. >2845: test->Run(); 2846: } 2847: 2848: if (test != nullptr) { #3 Source "_deps/gtest-src/googletest/src/gtest.cc", line 2696, in Run 2693: // GTEST_SKIP(). 2694: if (!HasFatalFailure() && !IsSkipped()) { 2695: impl->os_stack_trace_getter()->UponLeavingGTest(); >2696: internal::HandleExceptionsInMethodIfSupported(this, &Test::TestBody, 2697: "the test body"); 2698: } #2 | Source "_deps/gtest-src/googletest/src/gtest.cc", line 2657, in HandleSehExceptionsInMethodIfSupported<testing::Test, void> | 2655: #if GTEST_HAS_EXCEPTIONS | 2656: try { | >2657: return HandleSehExceptionsInMethodIfSupported(object, method, location); | 2658: } catch (const AssertionException&) { // NOLINT | 2659: // This failure was reported already. Source "_deps/gtest-src/googletest/src/gtest.cc", line 2621, in HandleExceptionsInMethodIfSupported<testing::Test, void> 2618: } 2619: #else 2620: (void)location; >2621: return (object->*method)(); 2622: #endif // GTEST_HAS_SEH 2623: } #1 Source "/mnt/user-data/adam/aztec-packages/barretenberg/cpp/src/barretenberg/circuit_checker/standard_circuit_builder.test.cpp", line 464, in TestBody 461: uint32_t d_idx = circuit_constructor.add_variable(d); 462: circuit_constructor.create_add_gate({ a_idx, b_idx, c_idx, fr::one(), fr::one(), fr::neg_one(), fr::zero() }); 463: > 464: circuit_constructor.create_add_gate({ d_idx, c_idx, a_idx, fr::one(), fr::neg_one(), fr::neg_one(), fr::zero() }); 465: 466: bool result = CircuitChecker::check(circuit_constructor); 467: EXPECT_EQ(result, false); #0 Source "/mnt/user-data/adam/aztec-packages/barretenberg/cpp/src/barretenberg/stdlib_circuit_builders/standard_circuit_builder.cpp", line 22, in create_add_gate 19: { 20: this->assert_valid_variables({ in.a, in.b, in.c }); 21: > 22: blocks.arithmetic.populate_wires(in.a, in.b, in.c); 23: blocks.arithmetic.q_m().emplace_back(FF::zero()); 24: blocks.arithmetic.q_1().emplace_back(in.a_scaling); 25: blocks.arithmetic.q_2().emplace_back(in.b_scaling); gate number4 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Once started, the P2P module should use it's configured rollup source to retrieve rollups and reconcile it's tx pool. It should report it's current synced rollup number via a status interface. This interface should indicate it's status via a 'state' value on it's status interface.
The text was updated successfully, but these errors were encountered: