Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update how tx effects are encoded in a block #4720

Closed
Tracked by #3533
benesjan opened this issue Feb 22, 2024 · 2 comments
Closed
Tracked by #3533

Update how tx effects are encoded in a block #4720

benesjan opened this issue Feb 22, 2024 · 2 comments

Comments

@benesjan
Copy link
Contributor

benesjan commented Feb 22, 2024 •
edited
Loading

Currently we don't encode tx effects in a block as a blob of continuous data but instead the note hashes and nullifiers are grouped. This should be addressed and TxEffect.toBuffer and fromBuffer functionality should be used.

Look for "TODO(#4720)" in the codebase.
@github-project-automation github-project-automation bot moved this to Todo in A3 Feb 22, 2024
@LHerskind
Copy link
Contributor

This seems somewhat related to #3938

@LHerskind LHerskind mentioned this issue Feb 28, 2024
Closed
@benesjan
Copy link
Contributor Author

benesjan commented Mar 1, 2024

Addressed by #3938

@benesjan benesjan closed this as completed Mar 1, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benesjan @LHerskind