Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: redo typo PR by longxiangqiao #11109

Merged
merged 1 commit into from
Jan 8, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aztec-nargo/compile_then_postprocess.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ fi
shift # remove the compile arg so we can inject --show-artifact-paths

# Forward all arguments to nargo, tee output to console.
# Nargo should be outputing errors to stderr, but it doesn't. Use tee to duplicate stdout to stderr to display errors.
# Nargo should be outputting errors to stderr, but it doesn't. Use tee to duplicate stdout to stderr to display errors.
artifacts_to_process=$($NARGO compile --inliner-aggressiveness 0 --show-artifact-paths $@ | tee >(cat >&2) | grep -oP 'Saved contract artifact to: \K.*')

# Postprocess each artifact
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ void ClientIVC::instantiate_stdlib_verification_queue(
*
* @param circuit The circuit to which the constraints are appended
* @param proof A stdlib proof to be recursively verified (either oink or PG)
* @param vkey The stdlib verfication key associated with the proof
* @param vkey The stdlib verification key associated with the proof
* @param type The type of the proof (equivalently, the type of the verifier)
*/
void ClientIVC::perform_recursive_verification_and_databus_consistency_checks(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ class ClientIVCTests : public ::testing::Test {
/**
* @brief A simple-as-possible test demonstrating IVC for two mock circuits
* @details When accumulating only two circuits, only a single round of folding is performed thus no recursive
* verfication occurs.
* verification occurs.
*
*/
TEST_F(ClientIVCTests, Basic)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class AvmComposer {
// The crs_factory holds the path to the srs and exposes methods to extract the srs elements
std::shared_ptr<bb::srs::factories::CrsFactory<Flavor::Curve>> crs_factory_;

// The commitment key is passed to the prover but also used herein to compute the verfication key commitments
// The commitment key is passed to the prover but also used herein to compute the verification key commitments
std::shared_ptr<CommitmentKey> commitment_key;

bool computed_witness = false;
Expand Down
2 changes: 1 addition & 1 deletion bb-pilcom/bb-pil-backend/src/relation_builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ fn create_identity<F: FieldElement>(
label: &Option<String>,
indexed_aliases: &HashMap<&String, &AlgebraicExpression<F>>,
) -> Option<BBIdentity> {
// We want to read the types of operators and then create the appropiate code
// We want to read the types of operators and then create the appropriate code
if let Some(expr) = &expression.selector {
let (degree, id, col_aliases) = recurse_expression(expr, indexed_aliases, false);
collected_aliases.extend(col_aliases);
Expand Down
2 changes: 1 addition & 1 deletion bb-pilcom/bb-pil-backend/src/vm_builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ struct ColumnGroups {
shifted: Vec<String>,
/// fixed + witness + shifted
all_cols_with_shifts: Vec<String>,
/// Inverses from lookups and permuations
/// Inverses from lookups and permutations
inverses: Vec<String>,
/// Public inputs (in source order)
public_inputs: Vec<(usize, String)>,
Expand Down
2 changes: 1 addition & 1 deletion bb-pilcom/bb-pil-backend/templates/composer.hpp.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class AvmComposer {
// The crs_factory holds the path to the srs and exposes methods to extract the srs elements
std::shared_ptr<bb::srs::factories::CrsFactory<Flavor::Curve>> crs_factory_;

// The commitment key is passed to the prover but also used herein to compute the verfication key commitments
// The commitment key is passed to the prover but also used herein to compute the verification key commitments
std::shared_ptr<CommitmentKey> commitment_key;

bool computed_witness = false;
Expand Down
Loading