Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(avm): run transpiler in ci #4258

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Conversation

Maddiaa0
Copy link
Member

@Maddiaa0 Maddiaa0 commented Jan 29, 2024

Adds avm-simulator build to ci such that it can be ran within noir-contracts build

  1. Create binary
  2. Copy binary in yarn-project-base
  3. Run binary in noir contracts build - in yarn project build

@Maddiaa0 Maddiaa0 changed the title temp: transpiler ci feat(avm): run transpiler in ci Jan 29, 2024
@Maddiaa0 Maddiaa0 force-pushed the md/transpiler-ci-builds branch from 8861397 to b7e00f8 Compare January 29, 2024 15:53
@Maddiaa0 Maddiaa0 force-pushed the md/transpiler-ci-builds branch from b7e00f8 to f2423ee Compare January 29, 2024 15:56
@Maddiaa0 Maddiaa0 marked this pull request as ready for review January 29, 2024 16:05
@Maddiaa0 Maddiaa0 requested a review from charlielye as a code owner January 29, 2024 16:05
@Maddiaa0 Maddiaa0 requested a review from dbanks12 January 29, 2024 16:06
@AztecBot
Copy link
Collaborator

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 80be57d6 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45,412 179,524 716,068
l1_rollup_calldata_gas 221,680 866,524 3,448,360
l1_rollup_execution_gas 314,167 984,264 3,668,017
l2_block_processing_time_in_ms 1,178 (+2%) 4,427 (+2%) 17,399
note_successful_decrypting_time_in_ms 264 (+5%) 916 (+2%) 3,485 (+2%)
note_trial_decrypting_time_in_ms 79.1 (+28%) 45.6 (-71%) 149 (-1%)
l2_block_building_time_in_ms 16,517 (+1%) 65,220 (+1%) 261,590 (+1%)
l2_block_rollup_simulation_time_in_ms 11,899 (+1%) 46,940 188,968
l2_block_public_tx_process_time_in_ms 4,585 (+1%) 18,152 (+1%) 72,338 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 13,713 (-3%) 25,730 (-6%)
note_history_successful_decrypting_time_in_ms 2,164 (+3%) 4,256 (-5%)
note_history_trial_decrypting_time_in_ms 135 (-51%) 184 (-21%)
node_database_size_in_bytes 17,289,296 32,993,360
pxe_database_size_in_bytes 29,923 59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 222 (+1%) 44,777 26,073
private-kernel-ordering 180 (+1%) 44,393 14,809
base-rollup 1,261 (+1%) 128,850 881
root-rollup 82.6 (+1%) 4,088 677
private-kernel-inner 314 (+1%) 71,816 26,073
public-kernel-private-input 218 (+1%) 32,375 26,073
public-kernel-non-first-iteration 216 (+1%) 32,417 26,073
merge-rollup 7.74 (+1%) 2,608 881

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 2 leaves 8 leaves 16 leaves 32 leaves 128 leaves 64 leaves 512 leaves 1024 leaves 2048 leaves 8192 leaves
batch_insert_into_append_only_tree_16_depth_ms 10.3 10.9 (-7%) 12.9 (+2%) 16.9 28.0 (+22%) 64.4 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.9 17.5 23.0 31.6 47.0 143 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.595 0.609 (-3%) 0.547 (+1%) 0.524 0.587 (+22%) 0.443 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A N/A N/A N/A 74.8 (-3%) 47.5 242 (+1%) 461 913 (+1%) 3,583
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A N/A N/A N/A 159 96.0 543 1,055 2,079 8,223
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A N/A N/A N/A 0.462 (-2%) 0.487 0.441 (+1%) 0.431 0.435 (+1%) 0.430
batch_insert_into_indexed_tree_20_depth_ms N/A N/A N/A N/A N/A 104 (-1%) 56.8 355 (+2%) 689 1,379 (+1%) 5,437
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A N/A N/A N/A 197 104 691 1,363 2,707 10,771
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A N/A N/A N/A 0.493 (-1%) 0.496 0.482 (+1%) 0.474 0.476 (+1%) 0.473
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A 56.7 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A 94.1 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A 0.579 N/A N/A N/A N/A N/A N/A N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 15,455 32,993

Transaction processing duration by data writes.

Metric 0 new commitments 1 new commitments
tx_pxe_processing_time_ms 399 (+1%) 1,130 (+1%)
Metric 1 public data writes
tx_sequencer_processing_time_ms 562 (+1%)

@dbanks12 dbanks12 merged commit 8b8c472 into db/avm-transpiler Jan 29, 2024
85 of 86 checks passed
@dbanks12 dbanks12 deleted the md/transpiler-ci-builds branch January 29, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants