Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sync from noir #6203

Merged
merged 6 commits into from
May 4, 2024
Merged

feat: Sync from noir #6203

merged 6 commits into from
May 4, 2024

Conversation

AztecBot
Copy link
Collaborator

@AztecBot AztecBot commented May 3, 2024

Automated pull of development from the noir programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
feat: Optimize array sets in if conditions (alternate version) (noir-lang/noir#4716)
chore: rename instruction checks for side effects (noir-lang/noir#4945)
chore: Switch Noir JS to use execute program instead of circuit (noir-lang/noir#4965)
fix: Use annotated type when checking declaration (noir-lang/noir#4966)
feat: handle empty response foreign calls without an external resolver (noir-lang/noir#4959)
feat: Complex outputs from acir call (noir-lang/noir#4952)
END_COMMIT_OVERRIDE

AztecBot and others added 4 commits May 3, 2024 19:01
…sion) (noir-lang/noir#4716)

chore: rename instruction checks for side effects (noir-lang/noir#4945)
chore: Switch Noir JS to use execute program instead of circuit (noir-lang/noir#4965)
fix: Use annotated type when checking declaration (noir-lang/noir#4966)
feat: handle empty response foreign calls without an external resolver (noir-lang/noir#4959)
feat: Complex outputs from acir call (noir-lang/noir#4952)
@TomAFrench
Copy link
Member

CI failures are due to me not updating bb.js to use portalled version.

Copy link
Contributor

github-actions bot commented May 3, 2024

Changes to circuit sizes

Generated at commit: 6715b6232614f4e4729d25aed9ad3684b4bbabd9, compared to commit: 4b432951a9fe46ca1b0e0d38ebafe523bebf04eb

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_inner -3 ✅ -0.00% -3 ✅ -0.00%
private_kernel_init -3 ✅ -0.00% -3 ✅ -0.00%
public_kernel_teardown -27 ✅ -0.04% -27 ✅ -0.01%
public_kernel_setup -27 ✅ -0.04% -27 ✅ -0.01%
rollup_base -224 ✅ -0.14% -192 ✅ -0.01%
public_kernel_app_logic -2,270 ✅ -2.54% -3,801 ✅ -0.98%
public_kernel_tail -78 ✅ -0.02% -13,980 ✅ -1.00%
private_kernel_tail -29,099 ✅ -17.64% -29,099 ✅ -2.67%
private_kernel_tail_to_public -68,793 ✅ -16.46% -68,793 ✅ -4.29%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_inner 106,972 (-3) -0.00% 380,703 (-3) -0.00%
private_kernel_init 91,742 (-3) -0.00% 285,730 (-3) -0.00%
public_kernel_teardown 71,926 (-27) -0.04% 301,994 (-27) -0.01%
public_kernel_setup 71,785 (-27) -0.04% 301,858 (-27) -0.01%
rollup_base 164,872 (-224) -0.14% 1,719,959 (-192) -0.01%
public_kernel_app_logic 86,970 (-2,270) -2.54% 382,778 (-3,801) -0.98%
public_kernel_tail 382,050 (-78) -0.02% 1,379,932 (-13,980) -1.00%
private_kernel_tail 135,879 (-29,099) -17.64% 1,062,719 (-29,099) -2.67%
private_kernel_tail_to_public 349,077 (-68,793) -16.46% 1,535,535 (-68,793) -4.29%

@TomAFrench TomAFrench merged commit 3ed41a0 into master May 4, 2024
61 checks passed
@TomAFrench TomAFrench deleted the sync-noir branch May 4, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants