Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable gcc ci + fix compilation #6591

Merged
merged 4 commits into from
May 22, 2024
Merged

fix: enable gcc ci + fix compilation #6591

merged 4 commits into from
May 22, 2024

Conversation

IlyasRidhuan
Copy link
Contributor

@IlyasRidhuan IlyasRidhuan commented May 22, 2024

Adds gcc to CI. Should fix gcc compilation by add missing initializers.

@ludamad ludamad enabled auto-merge (squash) May 22, 2024 12:39
@ludamad ludamad changed the title fix: add missing initializers fix: enable gcc ci + fix compilation May 22, 2024
@ludamad ludamad merged commit a575708 into master May 22, 2024
74 of 76 checks passed
@ludamad ludamad deleted the ir/gcc-fix branch May 22, 2024 13:13
@AztecBot
Copy link
Collaborator

Benchmark results

No base data found for comparison.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric 1 threads 4 threads 16 threads 32 threads 64 threads
proof_construction_time_sha256 5,690 1,547 714 756 777

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 772 772 772
l1_rollup_calldata_gas 6,856 6,868 6,868
l1_rollup_execution_gas 587,396 587,408 587,408
l2_block_processing_time_in_ms 1,362 5,112 10,182
l2_block_building_time_in_ms 32,599 127,870 254,614
l2_block_rollup_simulation_time_in_ms 32,394 127,131 253,233
l2_block_public_tx_process_time_in_ms 17,524 70,148 143,713

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 15,420 28,538
node_database_size_in_bytes 21,258,320 37,822,544
pxe_database_size_in_bytes 29,868 59,425

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit protocol_circuit_simulation_time_in_ms protocol_circuit_witness_generation_time_in_ms protocol_circuit_proving_time_in_ms protocol_circuit_input_size_in_bytes protocol_circuit_output_size_in_bytes protocol_circuit_proof_size_in_bytes protocol_circuit_num_public_inputs protocol_circuit_size_in_gates
private-kernel-init 159 3,684 23,165 19,985 61,999 86,720 2,643 1,048,576
private-kernel-inner 603 5,196 40,366 89,053 61,999 86,720 2,643 2,097,152
private-kernel-reset-small 572 2,479 23,408 117,961 61,999 86,720 2,643 1,048,576
private-kernel-tail 527 2,888 39,801 86,849 79,454 10,688 267 2,097,152
base-parity 6.56 2,022 4,174 128 64.0 2,208 2.00 131,072
root-parity 49.4 63.4 41,641 27,064 64.0 2,720 18.0 2,097,152
base-rollup 722 2,378 43,243 111,158 957 3,136 31.0 2,097,152
root-rollup 94.1 49.6 8,366 11,518 821 3,456 41.0 524,288
public-kernel-app-logic 243 139 749 96,978 85,095 116,448 3,572 4,096
public-kernel-tail 869 710 1,159 388,207 7,755 10,176 251 512
public-kernel-setup 226 200 748 138,309 85,095 116,448 3,572 4,096
public-kernel-teardown 223 220 1,087 143,320 85,095 116,448 3,572 4,096
merge-rollup 6.49 20.6 1,620 2,760 957 3,136 31.0 65,536
private-kernel-tail-to-public N/A 10,187 72,422 N/A N/A 116,960 3,588 4,194,304

Stats on running time collected for app circuits

Function app_circuit_proof_size_in_bytes app_circuit_proving_time_in_ms app_circuit_size_in_gates app_circuit_num_public_inputs
SchnorrAccount:entrypoint 16,128 47,528 2,097,152 437
Test:emit_nullifier 16,128 2,496 65,536 437
FPC:fee_entrypoint_public 16,128 8,410 524,288 437
FPC:fee_entrypoint_private 16,128 8,859 524,288 437
Token:unshield 16,128 49,441 2,097,152 437
SchnorrAccount:spend_private_authwit 16,128 2,675 131,072 437
Token:transfer 16,128 34,878 2,097,152 437

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 11.3 18.5 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.7 31.8 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.658 0.566 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 53.2 82.7 266 508 1,010 1,992 N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 95.9 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.544 0.510 0.483 0.474 0.478 0.475 N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 63.5 120 378 746 1,474 2,930 N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 106 208 692 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.551 0.537 0.512 0.513 0.510 0.509 N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 68.3
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 108
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.597

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 84,741 673,219

Transaction size based on fee payment method

| Metric | |
| - | |

Transaction processing duration by data writes.

Metric 0 new note hashes 1 new note hashes 2 new note hashes
tx_pxe_processing_time_ms 29,442 4,255 100,543
Metric 0 public data writes 1 public data writes 2 public data writes 4 public data writes 8 public data writes
tx_sequencer_processing_time_ms 1,381 2,217 2,000 3,126 1,977

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants