-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vm): executor for public kernel inputs #6716
feat(vm): executor for public kernel inputs #6716
Conversation
Benchmark resultsMetrics with a significant change:
Detailed resultsAll benchmarks are run on txs on the This benchmark source data is available in JSON format on S3 here. Proof generationEach column represents the number of threads used in proof generation.
L2 block published to L1Each column represents the number of txs on an L2 block published to L1.
L2 chain processingEach column represents the number of blocks on the L2 chain where each block has 16 txs.
Circuits statsStats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.
Stats on running time collected for app circuits
Tree insertion statsThe duration to insert a fixed batch of leaves into each tree type.
MiscellaneousTransaction sizes based on how many contract classes are registered in the tx.
Transaction size based on fee payment method | Metric | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Please look at my comments.
barretenberg/cpp/src/barretenberg/vm/tests/avm_execution.test.cpp
Outdated
Show resolved
Hide resolved
barretenberg/cpp/src/barretenberg/vm/tests/avm_execution.test.cpp
Outdated
Show resolved
Hide resolved
barretenberg/cpp/src/barretenberg/vm/tests/avm_execution.test.cpp
Outdated
Show resolved
Hide resolved
barretenberg/cpp/src/barretenberg/vm/tests/avm_execution.test.cpp
Outdated
Show resolved
Hide resolved
b084639
to
a4290c4
Compare
9f0c44f
to
5dcb1d4
Compare
a4290c4
to
42c3d82
Compare
42c3d82
to
d2355ee
Compare
Co-authored-by: Jean M <[email protected]>
d3bc173
into
md/05-30-chore_add_l1_to_l2_msg_read_requests_to_public_circuit_public_inputs
Overview
Adds executor for public kernel inputs
This executor runs using public_inputs_vec which will be the entire
PublicCircuitPublicInputs
that the ts vm simulator should have crafted after execution.