chore: Goblin cleanup

[ledwards2225]

Goblin cleanup/refactoring including:

• Splitting Goblin into prover and verifier classes to match model used elsewhere and to prep for forthcoming implementation of GoblinRecursiveVerifier
• Adding a new Goblin test suite
• Moving some goblin related types to a types.hpp file

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,720	1,547	698	764 (-2%)	768 (-1%)
proof_construction_time_sha256_30_ms	11,714 (-1%)	3,139	1,402	1,428 (-1%)	1,473 (+1%)
proof_construction_time_sha256_100_ms	43,689	11,769	5,422	5,424 (+1%)	5,363
proof_construction_time_poseidon_hash_ms	78.0 (-1%)	34.0	34.0 (-3%)	58.0	88.0 (+2%)
proof_construction_time_poseidon_hash_30_ms	1,517	417	201	227 (-1%)	267
proof_construction_time_poseidon_hash_100_ms	5,728	1,561	725	781 (-3%)	799

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	1,412	1,412	1,412
l1_rollup_calldata_gas	9,452	9,452	9,452
l1_rollup_execution_gas	616,093	616,093	616,093
l2_block_processing_time_in_ms	1,292 (-4%)	4,809 (-1%)	9,521 (-1%)
l2_block_building_time_in_ms	45,631	181,802	363,177
l2_block_rollup_simulation_time_in_ms	45,456	181,165	361,922
l2_block_public_tx_process_time_in_ms	25,102	102,906 (-1%)	210,334

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	9,440 (-1%)	14,407 (-1%)
node_database_size_in_bytes	14,504,016	21,291,088
pxe_database_size_in_bytes	18,071	29,868

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	proving_time_in_ms	input_size_in_bytes	output_size_in_bytes	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	135	502 (+2%)	13,204 (+7%)	20,630	64,614	89,536	2,731	524,288
private-kernel-inner	410 (+1%)	1,001	42,288 (+7%)	92,318	64,614	89,536	2,731	2,097,152
private-kernel-tail	585 (+1%)	2,846 (-9%)	35,983 (-2%)	96,541	77,732	11,648	297	2,097,152
base-parity	6.55 (-1%)	1,262	2,906	128	64.0	2,208	2.00	131,072
root-parity	50.0	62.5 (+4%)	44,380 (-1%)	27,084	64.0	2,720	18.0	2,097,152
base-rollup	763 (+5%)	2,317	74,833 (-1%)	119,734	756	3,648	47.0	4,194,304
root-rollup	112	63.0 (-2%)	19,284 (-2%)	25,297	620	3,456	41.0	1,048,576
public-kernel-app-logic	539 (+1%)	3,120 (+1%)	48,053	105,253	86,550	116,768	3,582	2,097,152
public-kernel-tail	1,125	23,527 (+5%)	154,503	401,002	7,646	11,648	297	8,388,608
private-kernel-reset-small	590 (+1%)	2,148 (+1%)	45,395 (-2%)	120,733	64,614	89,536	2,731	2,097,152
merge-rollup	28.5 (-2%)	N/A	N/A	16,534	756	N/A	N/A	N/A
public-kernel-setup	635 (-1%)	N/A	N/A	105,253	86,550	N/A	N/A	N/A
public-kernel-teardown	537 (-1%)	N/A	N/A	105,253	86,550	N/A	N/A	N/A
private-kernel-tail-to-public	N/A	8,696 (+2%)	92,727 (+2%)	N/A	N/A	116,768	3,582	4,194,304

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms	size_in_gates	num_public_inputs
ContractClassRegisterer:register	1,344	9,944	467	N/A	N/A	N/A	N/A
ContractInstanceDeployer:deploy	1,408	9,944	42.2 (+1%)	N/A	N/A	N/A	N/A
MultiCallEntrypoint:entrypoint	1,920	9,944	1,736 (+2%)	N/A	N/A	N/A	N/A
SchnorrAccount:constructor	1,312	9,944	1,504 (+2%)	N/A	N/A	N/A	N/A
SchnorrAccount:entrypoint	2,304	9,944	2,636	16,768	48,937 (-1%)	2,097,152	457
Token:privately_mint_private_note	1,280	9,944	1,638	N/A	N/A	N/A	N/A
Token:transfer	1,376	9,944	5,182 (+3%)	16,768	54,668 (+15%)	2,097,152	457
Benchmarking:create_note	1,344	9,944	1,400 (-1%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_public	1,344	9,944	228	N/A	N/A	N/A	N/A
SchnorrAccount:spend_private_authwit	1,280	9,944	81.7 (+6%)	N/A	N/A	N/A	N/A
Token:unshield	1,376	9,944	3,727	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_private	1,376	9,944	4,584 (+1%)	N/A	N/A	N/A	N/A

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.4 (-1%)	17.0	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.7	31.8	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.606 (-1%)	0.521	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	48.4 (-1%)	76.2 (-1%)	248	474 (-1%)	929 (-1%)	1,840 (-1%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.495 (-1%)	0.470 (-1%)	0.449 (-1%)	0.442 (-1%)	0.440 (-1%)	0.439 (-1%)	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	58.1 (-1%)	112 (-1%)	356 (-1%)	698	1,387 (-1%)	2,761 (-1%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	106	208	692	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.503	0.504	0.482 (-1%)	0.480	0.479	0.479 (-1%)	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	62.5
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	107
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.554

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	84,050	665,267

Transaction size based on fee payment method

| Metric | |
| - | |

[AztecBot]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'C++ Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.

Benchmark suite	Current: ca7a993	Previous: fb7c811	Ratio
Goblin::merge(t)	226389452 ns/iter	200097904 ns/iter	1.13

This comment was automatically generated by workflow using github-action-benchmark.

CC: @ludamad @codygunton

[lucasxia01]

LGTM