Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add code-workspace and update build dirs #6723

Merged
merged 1 commit into from
May 28, 2024

Conversation

codygunton
Copy link
Contributor

@codygunton codygunton commented May 28, 2024

Adds a set of VS Code settings in proving-systems.code-workspace akin to what we have in barretenberg.code-workspace, but situated at the top of the monorepo so that it's easier to work across the full stack. It also changes the build dir for debug and with-asserts builds to give a better incremental workflow.

@codygunton codygunton requested a review from ledwards2225 May 28, 2024 20:33
@codygunton codygunton changed the title Add code-workspace and update build dirs. feat: Add code-workspace and update build dirs May 28, 2024
Copy link
Contributor

@ledwards2225 ledwards2225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tested building in release and debug. All of my extensions seem to work as normal. I'm sure there will be a kink or two but seems to work well as is

@AztecBot
Copy link
Collaborator

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric 1 threads 4 threads 16 threads 32 threads 64 threads
proof_construction_time_sha256 5,794 (-1%) 1,554 (-1%) 712 (-1%) 762 (-3%) 776

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 1,412 1,412 1,412
l1_rollup_calldata_gas 9,464 9,452 9,476
l1_rollup_execution_gas 616,105 616,093 616,117
l2_block_processing_time_in_ms 1,297 4,842 9,584 (-1%)
l2_block_building_time_in_ms 44,794 177,536 354,671
l2_block_rollup_simulation_time_in_ms 44,623 176,892 353,407
l2_block_public_tx_process_time_in_ms 24,056 100,568 204,942

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 3 blocks 5 blocks
node_history_sync_time_in_ms 9,501 14,490 (+1%)
node_database_size_in_bytes 14,479,440 21,344,336
pxe_database_size_in_bytes 18,071 29,868

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit simulation_time_in_ms witness_generation_time_in_ms proving_time_in_ms input_size_in_bytes output_size_in_bytes proof_size_in_bytes num_public_inputs size_in_gates
private-kernel-init 159 (-1%) 3,703 (-1%) 22,416 (+2%) 20,630 64,614 89,536 2,731 1,048,576
private-kernel-inner 624 4,412 (+2%) 43,095 (-7%) 92,318 64,614 89,536 2,731 2,097,152
private-kernel-tail 567 3,203 (+8%) 36,670 (+2%) 96,541 77,498 10,656 266 2,097,152
base-parity 6.54 (-1%) 1,225 (+7%) 2,907 (-1%) 128 64.0 2,208 2.00 131,072
root-parity 49.6 (-1%) 60.7 (+24%) 44,514 (+1%) 27,084 64.0 2,720 18.0 2,097,152
base-rollup 764 (+2%) 2,207 (-3%) 74,572 (+1%) 119,610 756 3,648 47.0 4,194,304
root-rollup 112 64.1 (-2%) 20,124 (+2%) 25,297 620 3,456 41.0 1,048,576
public-kernel-app-logic 522 2,949 (-1%) 47,830 104,941 86,302 114,784 3,520 2,097,152
public-kernel-tail 1,081 22,375 (-2%) 154,997 395,386 7,522 10,656 266 8,388,608
private-kernel-reset-small 592 2,075 (-4%) 45,476 (+1%) 120,733 64,614 89,536 2,731 2,097,152
merge-rollup 28.8 (-1%) N/A N/A 16,534 756 N/A N/A N/A
public-kernel-setup 622 N/A N/A 104,941 86,302 N/A N/A N/A
public-kernel-teardown 529 N/A N/A 104,941 86,302 N/A N/A N/A
private-kernel-tail-to-public N/A 8,590 (-3%) 91,264 (-1%) N/A N/A 114,784 3,520 4,194,304

Stats on running time collected for app circuits

Function input_size_in_bytes output_size_in_bytes witness_generation_time_in_ms proof_size_in_bytes proving_time_in_ms size_in_gates num_public_inputs
ContractClassRegisterer:register 1,344 9,944 464 (-1%) N/A N/A N/A N/A
ContractInstanceDeployer:deploy 1,408 9,944 42.1 (+1%) N/A N/A N/A N/A
MultiCallEntrypoint:entrypoint 1,920 9,944 1,439 N/A N/A N/A N/A
SchnorrAccount:constructor 1,312 9,944 1,000 N/A N/A N/A N/A
SchnorrAccount:entrypoint 2,304 9,944 2,087 16,768 51,188 2,097,152 457
Token:privately_mint_private_note 1,280 9,944 1,139 N/A N/A N/A N/A
Token:transfer 1,376 9,944 4,115 (+1%) 16,768 45,589 (-14%) 2,097,152 457
Benchmarking:create_note 1,312 9,944 953 (+1%) N/A N/A N/A N/A
FPC:fee_entrypoint_public 1,344 9,944 222 (+1%) N/A N/A N/A N/A
SchnorrAccount:spend_private_authwit 1,280 9,944 79.8 (+3%) N/A N/A N/A N/A
Token:unshield 1,376 9,944 3,431 (+5%) N/A N/A N/A N/A
FPC:fee_entrypoint_private 1,376 9,944 4,210 (+4%) N/A N/A N/A N/A

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 10.5 (-1%) 17.0 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.7 31.8 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.610 (-1%) 0.522 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 49.2 (+1%) 75.9 (-1%) 248 473 932 1,848 N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 95.9 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.503 (+1%) 0.468 (-1%) 0.451 (+1%) 0.442 0.442 0.440 N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 58.7 113 (+1%) 356 697 1,393 2,768 N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 106 208 692 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.508 0.504 0.483 (+1%) 0.479 0.480 0.480 N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 62.5
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 107
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.554

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 83,794 665,117

Transaction size based on fee payment method

| Metric | |
| - | |

@codygunton codygunton merged commit c373d15 into master May 28, 2024
85 of 87 checks passed
@codygunton codygunton deleted the cg/code-workspace-and-build-dirs branch May 28, 2024 21:12
TomAFrench added a commit that referenced this pull request May 29, 2024
* master:
  feat: prepare circuit output for validation (#6678)
  chore: stop building/publishing `acvm_backend.wasm` (#6584)
  chore: add bench programs (#6566)
  chore: make public data update requests, note hashes, and unencrypted logs readonly in TS (#6658)
  git subrepo push --branch=master noir-projects/aztec-nr
  git_subrepo.sh: Fix parent in .gitrepo file. [skip ci]
  chore: replace relative paths to noir-protocol-circuits
  git subrepo push --branch=master barretenberg
  feat: update honk recursion constraint (#6545)
  feat: Add code-workspace and update build dirs (#6723)
  feat: Sync from noir (#6717)
  feat: folding acir programs (#6685)
  feat: sumcheck part of ECCVM recursive verifier instantiated as an UltraCircuit (#6413)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants