feat: aztec start --pxe network=devnet #7705
Conversation
| address: AztecAddress.fromString(basicContractsInfo[`${key}L2`]), | ||
| initHash: Fr.fromString(basicContractsInfo[`${key}L2InitHash`]), | ||
| salt: Fr.fromString(basicContractsInfo[`${key}L2Salt`]), | ||
| artifact: await getContractArtifact(artifactName, userLog), |
There was a problem hiding this comment.
Might be worth refactoring how the contracts are saved on static.aztec.network now, before we have to maintain backwards compatibility, so that in the future if we do add new contracts, this code won't need to change. I'm thinking we could save them like this
{
"testCounter": {
"address": "...",
"initializationHash": "....",
"salt": "....",
"deployerAddress": "..."
}
}
Then loading them up in the pxe becomes just an iteration over the top-level keys.
There was a problem hiding this comment.
This isn't something that has to be done in this PR but we should consider doing it soon ™️
| const devCoin = await TokenContract.deploy(wallet, wallet.getAddress(), 'DevCoin', 'DEV', 18).send().deployed(); | ||
| const bridge = await TokenBridgeContract.deploy(wallet, devCoin.address, l1Portal).send().deployed(); | ||
| const devCoin = await TokenContract.deploy(wallet, wallet.getAddress(), 'DevCoin', 'DEV', 18) | ||
| .send({ universalDeploy: true }) |
There was a problem hiding this comment.
ah wait this isn't necessary, was trying this before Phil's change on storing initHash & salt
| @@ -53,6 +53,7 @@ | |||
| "@aztec/pxe": "workspace:^", | |||
| "@aztec/telemetry-client": "workspace:^", | |||
| "@aztec/txe": "workspace:^", | |||
| "@aztec/types": "workspace:^", | |||
There was a problem hiding this comment.
I got bit by it yesterday, this needs a yarn prepare at the root to update aztec/tsconfig.json 🥹
|
Just a heads up that the CI flow only runs on PRs to master so linter errors won't show up until we actually merge devnet to master |
Co-authored-by: Alex Gherghisan <[email protected]>
Co-authored-by: Alex Gherghisan <[email protected]>
| address: AztecAddress.fromString(basicContractsInfo[`${key}L2`]), | ||
| initHash: Fr.fromString(basicContractsInfo[`${key}L2InitHash`]), | ||
| salt: Fr.fromString(basicContractsInfo[`${key}L2Salt`]), | ||
| artifact: await getContractArtifact(artifactName, userLog), |
| * Deployed aztec networks & their names. | ||
| */ | ||
| export enum Network { | ||
| DEVNET = 'devnet', |
There was a problem hiding this comment.
Can you add 'provernet', with the same config as devnet please?
spypsy
force-pushed
the
spy/start-devnet-pxe
branch
from
075c835 to
0c9159a
Compare
Fixes #7644
Adds the
networkoption toaztec start --pxeUser will need to provide an API key in order to connect to our hosted node