This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
(sample): Device streaming sample improvements and fixes #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinagesh
requested review from
abhipsaMisra,
azabbasi,
barustum,
bikamani,
drwill-ms,
jamdavi and
timtay-microsoft
as code owners
vinagesh
commented
Dec 10, 2020
| @@ -16,6 +16,6 @@ | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="Microsoft.Azure.Devices.Client" Version="1.29.0-preview-*" /> | |||
| <PackageReference Include="Microsoft.Azure.Devices.Client" Version="1.32.0-preview-001" /> | |||
There was a problem hiding this comment.
Upgraded sample to use the latest version where this sample will work for net 5.0 as well
vinagesh
commented
Dec 10, 2020
| @@ -44,6 +44,8 @@ public async Task RunSampleAsync() | |||
|
|
|||
| var receiveResult = await stream.ReceiveAsync(receiveBuffer, cts.Token).ConfigureAwait(false); | |||
| Console.WriteLine($"Received stream data: {Encoding.UTF8.GetString(receiveBuffer, 0, receiveResult.Count)}"); | |||
|
|
|||
| await stream.CloseAsync(WebSocketCloseStatus.NormalClosure, "Streaming completed", new CancellationToken()); | |||
There was a problem hiding this comment.
The sample throws an exception without this
vinagesh
commented
Dec 10, 2020
|
|
||
| using ServiceClient serviceClient = ServiceClient.CreateFromConnectionString(s_connectionString, s_transportType); | ||
| var sample = new DeviceStreamSample(serviceClient, s_deviceId); | ||
| // Parse application parameters |
There was a problem hiding this comment.
Adding command line arguments for inputs
drwill-ms
reviewed
Dec 10, 2020
| [Option( | ||
| 't', | ||
| "TransportType", | ||
| Default = TransportType.Amqp, |
There was a problem hiding this comment.
The TransportType enum in our service client does not have MQTT.
drwill-ms
reviewed
Dec 10, 2020
drwill-ms
approved these changes
Dec 10, 2020
vinagesh
force-pushed
the
vinagesh/ds
branch
from
d224229 to
606850e
Compare
azabbasi
approved these changes
Dec 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the sample with some improvements