Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Choosing a more secure option should not come with a warning #621

Closed
mosabami opened this issue Jul 22, 2023 · 1 comment · Fixed by #623
Closed

Choosing a more secure option should not come with a warning #621

mosabami opened this issue Jul 22, 2023 · 1 comment · Fixed by #623
Assignees
@asalbers
Labels
good first issue Good for newcomers helper-ui 🧙‍♀️ An issue with the UI in the helper stale An issue that hasn't had a lot of love recently

Comments

@mosabami
Copy link
Contributor

Describe the bug
when Private cluster security option is chosen, it has a warning on it saying this is the most complicated option. It shouldnt warn but encourage people.

To Reproduce
Steps to reproduce the behavior:

  1. Got to the website
  2. Check out the Private cluster box under security principles

Expected behavior
Instead of issuing a warning it should instead say
"Note: Best option, but most complex to operate"
Leave the background color as is
@khowling khowling added good first issue Good for newcomers helper-ui 🧙‍♀️ An issue with the UI in the helper labels Jul 27, 2023
@asalbers asalbers mentioned this issue Jul 27, 2023
Merged
5 tasks
@github-actions
Copy link
Contributor

Issue smells stale, no activity for 30 days. Stale Label will be removed if the issue is updated, otherwise closed in a month.

@github-actions github-actions bot added the stale An issue that hasn't had a lot of love recently label Aug 27, 2023
Gordonby added a commit that referenced this issue Aug 31, 2023
@asalbers @mosabami @Gordonby
Choosing a more secure option should not come with a warning - #621 (#…
a4bc33c 
…623)

* changed note field

* changed additional file

* Update principals.json

* Update clusterTab.js

---------

Co-authored-by: Ayobami Ayodeji <[email protected]>
Co-authored-by: Gordon Byers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asalbers asalbers

Labels
good first issue Good for newcomers helper-ui 🧙‍♀️ An issue with the UI in the helper stale An issue that hasn't had a lot of love recently
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Choosing a more secure option should not come with a warning - #621 Azure/AKS-Construction
3 participants
@khowling @asalbers @mosabami