Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added error message when App GW and CNI Overlay are selected #672

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

pjlewisuk
Copy link
Contributor

PR Summary

Added error messages on Addon Details and Networking Details tabs when Azure Application Gateway ingress controller and Azure CNI Overlay Networking are selected. This resolves #653 and unblocks #633.

Screenshots below:

image
image

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue
  • Screenshot of UI changes (if PR includes UI changes)

@pjlewisuk pjlewisuk mentioned this pull request Nov 16, 2023
5 tasks
Copy link
Contributor

@samaea samaea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@pjlewisuk pjlewisuk enabled auto-merge (squash) November 16, 2023 20:05
@pjlewisuk pjlewisuk merged commit 71fe11f into main Nov 16, 2023
31 checks passed
@pjlewisuk pjlewisuk deleted the paullewis-653-overlay-ingress branch November 16, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application Gateway ingress controller not compatible with CNI Overlay
2 participants