This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 560
E2E test - 50 nodes #2260
Merged
Merged
E2E test - 50 nodes #2260
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
472504a
50 node cluster api model
jackfrancis 95b4ab4
more idiomatic 50 node cluster
jackfrancis a61c0eb
let’s try this
jackfrancis 1ef0e3b
managed disk needs availability set
jackfrancis de59b80
debug
jackfrancis 883c655
more debug
jackfrancis 7640178
more more debug
jackfrancis 5cb10d3
dynamic tiller max history e2e test
jackfrancis f97bbc7
tiller max-history test description
jackfrancis 0a8e718
remove debug, absorb ssh errors
jackfrancis c8e1c70
better debug
jackfrancis d864494
simplified tiller tests
jackfrancis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
39 changes: 39 additions & 0 deletions
39
examples/e2e-tests/kubernetes/node-count/50-nodes/definition.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
{ | ||
"apiVersion": "vlabs", | ||
"properties": { | ||
"orchestratorProfile": { | ||
"orchestratorType": "Kubernetes", | ||
"orchestratorRelease": "1.8" | ||
}, | ||
"masterProfile": { | ||
"count": 5, | ||
"dnsPrefix": "", | ||
"vmSize": "Standard_D2_v2", | ||
"OSDiskSizeGB": 200 | ||
}, | ||
"agentPoolProfiles": [ | ||
{ | ||
"name": "agentpool1", | ||
"count": 50, | ||
"vmSize": "Standard_D2_v2", | ||
"osType": "Linux", | ||
"storageProfile": "ManagedDisks", | ||
"availabilityProfile": "AvailabilitySet" | ||
} | ||
], | ||
"linuxProfile": { | ||
"adminUsername": "azureuser", | ||
"ssh": { | ||
"publicKeys": [ | ||
{ | ||
"keyData": "" | ||
} | ||
] | ||
} | ||
}, | ||
"servicePrincipalProfile": { | ||
"clientId": "", | ||
"secret": "" | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -125,23 +125,20 @@ var _ = Describe("Azure Container Cluster using the Kubernetes Orchestrator", fu | |
}) | ||
|
||
It("should have tiller running", func() { | ||
if eng.HasTiller() { | ||
if hasTiller, tillerAddon := eng.HasTiller(); hasTiller { | ||
running, err := pod.WaitOnReady("tiller", "kube-system", 3, 30*time.Second, cfg.Timeout) | ||
Expect(err).NotTo(HaveOccurred()) | ||
Expect(running).To(Equal(true)) | ||
} else { | ||
Skip("tiller disabled for this cluster, will not test") | ||
} | ||
}) | ||
|
||
It("should have a tiller max-history of 5", func() { | ||
if eng.HasTiller() { | ||
pods, err := pod.GetAllByPrefix("tiller-deploy", "kube-system") | ||
Expect(err).NotTo(HaveOccurred()) | ||
// There is only one tiller pod and one container in that pod. | ||
actualTillerMaxHistory, err := pods[0].Spec.Containers[0].GetEnvironmentVariable("TILLER_HISTORY_MAX") | ||
Expect(err).NotTo(HaveOccurred()) | ||
Expect(actualTillerMaxHistory).To(Equal("5")) | ||
if tillerAddon.Config != nil { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would this ever be nil? What happens if it is? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The current configuration enforces always non-nil: https://github.com/Azure/acs-engine/blob/master/pkg/acsengine/defaults.go#L752 So the above is just for good hygiene. |
||
By("Ensuring that the correct max-history has been applied") | ||
maxHistory := tillerAddon.Config["max-history"] | ||
pods, err := pod.GetAllByPrefix("tiller-deploy", "kube-system") | ||
Expect(err).NotTo(HaveOccurred()) | ||
// There is only one tiller pod and one container in that pod. | ||
actualTillerMaxHistory, err := pods[0].Spec.Containers[0].GetEnvironmentVariable("TILLER_HISTORY_MAX") | ||
Expect(err).NotTo(HaveOccurred()) | ||
Expect(actualTillerMaxHistory).To(Equal(maxHistory)) | ||
} | ||
} else { | ||
Skip("tiller disabled for this cluster, will not test") | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the docs (https://github.com/Azure/acs-engine/blob/master/docs/kubernetes-large-clusters.md)
We recommend the use of smaller pools (e.g., count of 20) over larger pools (e.g., count of 100); produce your desired total node count with lots of pools, as opposed to as few as possible.
Would it make sense to change this to several smaller pools since people are likely to look at example files and to copy them for their own implementation?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amanohar @khenidak Is the above guidance still valid? (i.e., don't use node pools > 20 count)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i admit this answer is not as clear as i would love it to be
From one end 50 nodes with 4+ pools will hit ARM template limit (800 object). From another, I really don't see a relationship between # of nodes per pool and scale. As long as we don't hit more than 100 per availability set (or scale set) we are fine.
Many pools are better because users will get extra load balancers (Extra public IPs), smaller blast radius (in case of failures). They are however harder to manager