Merge pull request #36 from SanyaKochhar/pr-comments-3

chore: address PR follow-up comments
Azure · Jun 15, 2021 · 98533c3 · 98533c3
2 parents 68730dc + f8be0cf
commit 98533c3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/deployment/aks-periscope.yaml b/deployment/aks-periscope.yaml
@@ -148,7 +148,7 @@ metadata:
   name: collectors-config
   namespace: aks-periscope
 data:
-  COLLECTOR_LIST: managedCluster # <custom flag> connectedCluster OSM
+  COLLECTOR_LIST: managedCluster # <custom flag>
 ---
 apiVersion: apiextensions.k8s.io/v1beta1
 kind: CustomResourceDefinition

diff --git a/pkg/utils/helper.go b/pkg/utils/helper.go
@@ -162,7 +162,7 @@ func RunBackgroundCommand(command string, arg ...string) (int, error) {
 	cmd.Stderr = &stderr
 	err := cmd.Start()
 	if err != nil {
-		return 0, fmt.Errorf("Fail to start background command in container: %s", fmt.Sprint(err)+": "+stderr.String())
+		return 0, fmt.Errorf("Start background command in container exited with message %s: %w", stderr.String(), err)
 	}
 	return cmd.Process.Pid, nil
 }
@@ -171,7 +171,7 @@ func RunBackgroundCommand(command string, arg ...string) (int, error) {
 func KillProcess(pid int) error {
 	process, err := os.FindProcess(pid)
 	if err != nil {
-		return fmt.Errorf("Failed to find process with pid %d to kill: %+v", pid, fmt.Sprint(err))
+		return fmt.Errorf("Find process with pid %d to kill: %w", pid, err)
 	}
 	if err := process.Kill(); err != nil {
 		return err