Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests from inside the cluster #114

Closed

Conversation

arnaud-tincelin
Copy link
Collaborator

No description provided.

@arnaud-tincelin arnaud-tincelin force-pushed the in-cluster-tests branch 30 times, most recently from 15c8fb3 to fe255dd Compare September 9, 2021 12:46
@arnaud-tincelin arnaud-tincelin force-pushed the in-cluster-tests branch 17 times, most recently from f53aed7 to 348d93e Compare September 9, 2021 17:55
@arnaud-tincelin arnaud-tincelin changed the title Run tests inside the cluster Run tests from inside the cluster Sep 9, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2021

Codecov Report

Merging #114 (c5cb3ac) into master (165e024) will decrease coverage by 9.45%.
The diff coverage is n/a.

❗ Current head c5cb3ac differs from pull request most recent head ec38867. Consider uploading reports for the commit ec38867 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
- Coverage   28.95%   19.49%   -9.46%     
==========================================
  Files          12       12              
  Lines         518      518              
==========================================
- Hits          150      101      -49     
- Misses        354      411      +57     
+ Partials       14        6       -8     
Impacted Files Coverage Δ
pkg/collector/pods_containerlogs_collector.go 25.00% <0.00%> (-52.78%) ⬇️
pkg/collector/helm_collector.go 32.60% <0.00%> (-43.48%) ⬇️
pkg/collector/networkoutbound_collector.go 87.50% <0.00%> (-4.17%) ⬇️
pkg/collector/nodelogs_collector.go 73.33% <0.00%> (ø)
pkg/collector/dns_collector.go 64.70% <0.00%> (+64.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 165e024...ec38867. Read the comment docs.

@arnaud-tincelin arnaud-tincelin force-pushed the in-cluster-tests branch 6 times, most recently from 09704d0 to 111abfa Compare September 9, 2021 18:56
@arnaud-tincelin arnaud-tincelin marked this pull request as ready for review September 9, 2021 19:07
@Tatsinnit
Copy link
Member

💡 Regarding codecov decrease I think we should close this PR and re-open as separate PR:

image

But Codecov is somehow stuck in random commit:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants