Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns logs will contain error rather than actual pod error visibility. #117

Merged

Conversation

Tatsinnit
Copy link
Member

@Tatsinnit Tatsinnit commented Sep 15, 2021

This is the work for ARC for log level error visibility in case od DNS logs than pods level error visibility.

Thanks,

  • Test image : docker.io/tatsat/dns-logs-visibility

Thank you guys ☕️ : @arnaud-tincelin , @sophsoph321 and @safeermohammed

@codecov-commenter
Copy link

Codecov Report

Merging #117 (179fe8d) into master (165e024) will increase coverage by 2.50%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
+ Coverage   28.95%   31.46%   +2.50%     
==========================================
  Files          12       12              
  Lines         518      518              
==========================================
+ Hits          150      163      +13     
+ Misses        354      340      -14     
- Partials       14       15       +1     
Impacted Files Coverage Δ
pkg/collector/dns_collector.go 76.47% <50.00%> (+76.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 165e024...179fe8d. Read the comment docs.

@Tatsinnit Tatsinnit self-assigned this Sep 15, 2021
Copy link
Collaborator

@sophsoph321 sophsoph321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified with the private image and changes look good.

@Tatsinnit Tatsinnit merged commit 118d62a into Azure:master Sep 16, 2021
@Tatsinnit Tatsinnit deleted the feature/dns-file-visibility-via-logs branch September 16, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants