Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement describe functionality via client-go apis. #120

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

Tatsinnit
Copy link
Member

@Tatsinnit Tatsinnit commented Sep 26, 2021

This is the PR with the intent to move away from kubectl binary and use the go-lang clients for Kubernetes. Improve test coverage/ability for the collectors of this repo as well.

Tested with Image: docker.io/tatsat/pod-describer it gives more data which could be handy.

Thanks,

cc: @arnaud-tincelin , @rzhang628 , @qpetraroia , @palma21 and @JunSun17 and fyi: @sophsoph321

sample logs

image

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2021

Codecov Report

Merging #120 (70e14fc) into master (118d62a) will increase coverage by 3.67%.
The diff coverage is 72.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
+ Coverage   31.46%   35.14%   +3.67%     
==========================================
  Files          12       12              
  Lines         518      515       -3     
==========================================
+ Hits          163      181      +18     
+ Misses        340      317      -23     
- Partials       15       17       +2     
Impacted Files Coverage Δ
pkg/collector/kubeobjects_collector.go 73.33% <70.58%> (+73.33%) ⬆️
pkg/collector/pods_containerlogs_collector.go 78.78% <100.00%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 118d62a...70e14fc. Read the comment docs.

@Tatsinnit Tatsinnit self-assigned this Sep 26, 2021
@Tatsinnit Tatsinnit added the enhancement 🏎 New feature or request label Sep 26, 2021
@Tatsinnit Tatsinnit changed the title handle description via client go apis. Implement describe functionality via client-go apis. Sep 26, 2021
@Tatsinnit Tatsinnit merged commit 3ac988a into Azure:master Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🏎 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants