Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible fix for the dependency alert. #122

Merged
merged 3 commits into from
Oct 7, 2021

Conversation

Tatsinnit
Copy link
Member

@Tatsinnit Tatsinnit commented Sep 28, 2021

Gave a quick try to fix the dependency alert regarding: github.com/containerd/containerd and github.com/opencontainers/runc cc: @arnaud-tincelin

Update: so seems like this will fix the dependency issue: I tested by enabling that in my fork with same commit and it stopped showing dependency alerts: https://github.com/Tatsinnit/aks-periscope

Note: These packages are not directly used and I believe this is probably used via helm go-lang packages.

private image: docker.io/tatsat/dependency-alert

cc: @rzhang628 and @qpetraroia for visibility.

Thanks,

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2021

Codecov Report

Merging #122 (08ca887) into master (f4237c0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   38.85%   38.85%           
=======================================
  Files          12       12           
  Lines         525      525           
=======================================
  Hits          204      204           
  Misses        304      304           
  Partials       17       17           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4237c0...08ca887. Read the comment docs.

@Tatsinnit Tatsinnit self-assigned this Sep 28, 2021
Copy link
Collaborator

@sophsoph321 sophsoph321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and these changes do not break arc scenarios

@Tatsinnit Tatsinnit merged commit 1358094 into Azure:master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants