Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pod distribution budget information collector. #135

Merged
merged 3 commits into from
Dec 7, 2021

Conversation

Tatsinnit
Copy link
Member

@Tatsinnit Tatsinnit commented Nov 17, 2021

This implementation is to collect the information which usually help folks for identification of Pod disruption budget related glitches.

This PR should take care of #134 , cc: @SriHarsha001 as he is aware of these logic essentially this is just raw collection of data which could help in identification of PDB related issues. Plus @bcho

Thanks. 🙏

@Tatsinnit Tatsinnit force-pushed the feature/poddisruptionbudgetlog branch from 7f87b40 to f600431 Compare November 18, 2021 03:15
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2021

Codecov Report

Merging #135 (e1ef4cb) into master (f55868b) will increase coverage by 0.94%.
The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage   38.62%   39.56%   +0.94%     
==========================================
  Files          12       13       +1     
  Lines         523      556      +33     
==========================================
+ Hits          202      220      +18     
- Misses        304      314      +10     
- Partials       17       22       +5     
Impacted Files Coverage Δ
pkg/collector/pdb_collector.go 54.54% <54.54%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f55868b...e1ef4cb. Read the comment docs.

@Tatsinnit Tatsinnit linked an issue Nov 18, 2021 that may be closed by this pull request
@Tatsinnit Tatsinnit self-assigned this Dec 2, 2021
pkg/collector/pdb_collector.go Outdated Show resolved Hide resolved
pkg/collector/pdb_collector.go Outdated Show resolved Hide resolved
@Tatsinnit Tatsinnit requested a review from bcho December 7, 2021 04:20
@Tatsinnit Tatsinnit merged commit 34e6a17 into Azure:master Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collect PDB related information.
4 participants