Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old redundant deployment file. #162

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

Tatsinnit
Copy link
Member

@Tatsinnit Tatsinnit commented Apr 5, 2022

This PR removes a very old deployment yaml file for periscope.

WE kept it as a grace period for its retirement but now the underlying image is also not reachable and the repo uses the kustomize way to build the deployment file as consumption.

Thank you

@peterbom if you can please review ❤️🙏☕️ this will also avoid confusion like happened here: #160

@Tatsinnit Tatsinnit requested a review from peterbom April 5, 2022 01:38
@Tatsinnit Tatsinnit self-assigned this Apr 5, 2022
@Tatsinnit Tatsinnit requested a review from rzhang628 April 5, 2022 01:38
@codecov-commenter
Copy link

Codecov Report

Merging #162 (99b2383) into master (855c9c9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #162   +/-   ##
=======================================
  Coverage   68.98%   68.98%           
=======================================
  Files          11       11           
  Lines         345      345           
=======================================
  Hits          238      238           
  Misses         85       85           
  Partials       22       22           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 855c9c9...99b2383. Read the comment docs.

@Tatsinnit Tatsinnit merged commit ea3c1f7 into Azure:master Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants