Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use client-go for SMI collector #179

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

peterbom
Copy link
Contributor

@peterbom peterbom commented Jun 8, 2022

Addresses #127

This is to take us one step further towards removing our reliance on the kubectl binary and parity between operating systems, making use of the KubeCommandRunner library dealing with Unstructured client-go types introduced in #178.

cc: @Tatsinnit, @SanyaKochhar

@peterbom peterbom linked an issue Jun 8, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #179 (2039041) into master (07ca8cc) will decrease coverage by 0.05%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
- Coverage   79.00%   78.94%   -0.06%     
==========================================
  Files          13       13              
  Lines         700      717      +17     
==========================================
+ Hits          553      566      +13     
- Misses         90       92       +2     
- Partials       57       59       +2     
Impacted Files Coverage Δ
pkg/collector/smi_collector.go 79.10% <80.00%> (-0.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07ca8cc...2039041. Read the comment docs.

@Tatsinnit Tatsinnit added the enhancement 🏎 New feature or request label Jun 9, 2022
Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 /lgtm, thanks, deferring to @SanyaKochhar for an eye ball please. thank you so much.

@Tatsinnit Tatsinnit merged commit 2377183 into Azure:master Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🏎 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor SMI collector to use client-go.
4 participants