Use os.open function for reading files. #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaud-tincelin
suggested changes
Aug 23, 2021
| @@ -24,7 +24,7 @@ func (collector *DNSCollector) GetName() string { | |||
| func (collector *DNSCollector) Collect() error { | |||
| result := make(map[string]string) | |||
|
|
|||
| output, err := utils.RunCommandOnHost("cat", "/etc/resolv.conf") | |||
| output, err := utils.ReadFileContent("/etc/resolv.conf") | |||
There was a problem hiding this comment.
The previous command was running on the host, this one will run on the container. Is it working as expected or should we have a mount to do that?
There was a problem hiding this comment.
Yeah, so they are already there: docker.io/tatsat/redundant-runcommand-use image shows the correct log.
| @@ -29,13 +29,12 @@ func (collector *NodeLogsCollector) Collect() error { | |||
|
|
|||
| for _, nodeLog := range nodeLogs { | |||
|
|
|||
| output, err := utils.RunCommandOnHost("cat", nodeLog) | |||
| output, err := utils.ReadFileContent(nodeLog) | |||
|
💡 FYI: closing this in favour for this PR: #109 - it makes sense to do this individually at the each collector level when adding tests. Which will lead to better progress. Thanks heaps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR kind of closes all the discussion where it was recommended not to use
RunCommandOnHostfor things likecatfor file because that can be easily done at viaos.Openwhich open files. Much better and reduces over-use ofRunCommandonHost.docker.io/tatsat/redundant-runcommand-useThanks.