Fix Invalid cast exception #112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, has someone already time to review this? @JonCole ? @SiddharthChatrolaMs ? |
|
Sorry about the delay but our team has been pretty slammed. Right now, I am working through most of the pull requests. |
|
Apologies for the incredibly long response time, I'm relatively new and the rest of our team hasn't had time to update the repo in quite a while. Do you have any more information about your configuration or how to reproduce this issue so that we can find the root cause? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves issue #111. I am not able to reproduce perfectly the cause of a problem so I proposed a defensive solution that is based on type checking and a fallback path if a chech fails.