Merge pull request #7 from yugangw-msft/fxcop

Address all fxcop violations and wire up command line support to run it in CI

Microsoft.Rest/ClientRuntime.Etw/ClientRuntime.Etw.csproj

@@ -35,6 +35,7 @@
   </PropertyGroup>
   <Import Project="$(SolutionDir)\tools\AutoRest.Settings.targets" />
   <ItemGroup>
+    <Compile Include="GlobalSuppressions.cs" />
     <Compile Include="HttpOperationEventSource.cs" />
     <Compile Include="EtwTracingInterceptor.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />

Microsoft.Rest/ClientRuntime.Etw/GlobalSuppressions.cs

@@ -0,0 +1,4 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License. See License.txt in the project root for license information.
+
+[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Design", "CA2210:AssembliesShouldHaveValidStrongNames", Justification="We do give it strong name and sign it when build in CI server and verify it")]

Microsoft.Rest/ClientRuntime.Log4Net/GlobalSuppressions.cs

@@ -2,4 +2,5 @@
 // Licensed under the MIT License. See License.txt in the project root for license information.
 
 [assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Globalization", "CA1305:SpecifyIFormatProvider", MessageId = "log4net.ILog.DebugFormat(System.String,System.Object[])", Scope = "member", Target = "Microsoft.Rest.Tracing.Log4Net.Log4NetTracingInterceptor.#Enter(System.String,System.Object,System.String,System.Collections.Generic.IDictionary`2<System.String,System.Object>)")]
-[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Globalization", "CA1305:SpecifyIFormatProvider", MessageId = "System.String.Format(System.String,System.Object,System.Object)", Scope = "member", Target = "Microsoft.Rest.Tracing.Log4Net.Log4NetTracingInterceptor.#Exit(System.String,System.Object)")]
+[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Globalization", "CA1305:SpecifyIFormatProvider", MessageId = "System.String.Format(System.String,System.Object,System.Object)", Scope = "member", Target = "Microsoft.Rest.Tracing.Log4Net.Log4NetTracingInterceptor.#Exit(System.String,System.Object)")]
+[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Design", "CA2210:AssembliesShouldHaveValidStrongNames", Justification="We do give it strong name and sign it when build in CI server and verify it")]

Microsoft.Rest/ClientRuntime.Tests/ClientRuntime.Tests.csproj

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
-<Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+<Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003" InitialTargets="TurnOffCodeAnalysis">
   <Import Project="..\..\packages\xunit.runner.visualstudio.0.99.9-build1021\build\net20\xunit.runner.visualstudio.props" Condition="Exists('..\..\packages\xunit.runner.visualstudio.0.99.9-build1021\build\net20\xunit.runner.visualstudio.props')" />
   <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
   <PropertyGroup>

Microsoft.Rest/ClientRuntime.Tests/ServiceClientTest.cs

@@ -64,7 +64,7 @@ public void RetryHandlerRetriesWith500Errors()
             int attemptsFailed = 0;
 
             fakeClient.SetRetryPolicy(new RetryPolicy<HttpStatusCodeErrorDetectionStrategy>(2));
-            var retryHandler = fakeClient.GetHttpPipeline().OfType<RetryDelegatingHandler>().FirstOrDefault();
+            var retryHandler = fakeClient.HttpPipelines.OfType<RetryDelegatingHandler>().FirstOrDefault();
             retryHandler.Retrying += (sender, args) => { attemptsFailed++; };
 
             var result = fakeClient.DoStuff();
@@ -79,7 +79,7 @@ public void RetryHandlerRetriesWith500ErrorsAndSucceeds()
             int attemptsFailed = 0;
 
             fakeClient.SetRetryPolicy(new RetryPolicy<HttpStatusCodeErrorDetectionStrategy>(2));
-            var retryHandler = fakeClient.GetHttpPipeline().OfType<RetryDelegatingHandler>().FirstOrDefault();
+            var retryHandler = fakeClient.HttpPipelines.OfType<RetryDelegatingHandler>().FirstOrDefault();
             retryHandler.Retrying += (sender, args) => { attemptsFailed++; };
 
             var result = fakeClient.DoStuff();
@@ -94,7 +94,7 @@ public void RetryHandlerDoesntRetryFor400Errors()
             int attemptsFailed = 0;
 
             fakeClient.SetRetryPolicy(new RetryPolicy<HttpStatusCodeErrorDetectionStrategy>(2));
-            var retryHandler = fakeClient.GetHttpPipeline().OfType<RetryDelegatingHandler>().FirstOrDefault();
+            var retryHandler = fakeClient.HttpPipelines.OfType<RetryDelegatingHandler>().FirstOrDefault();
             retryHandler.Retrying += (sender, args) => { attemptsFailed++; };
 
             var result = fakeClient.DoStuff();

Microsoft.Rest/ClientRuntime.Tests/TransientFaultHandling/DefaultHttpErrorDetectionStrategyTests.cs

@@ -21,7 +21,7 @@ public class DefaultHttpErrorDetectionStrategyTests
         public void ResponseCodeIsConsideredTransient(HttpStatusCode code)
         {
             var strategy = new HttpStatusCodeErrorDetectionStrategy();
-            Assert.True(strategy.IsTransient(new HttpRequestExceptionWithStatus { StatusCode = code }));
+            Assert.True(strategy.IsTransient(new HttpRequestWithStatusException { StatusCode = code }));
         }
 
         [Theory]
@@ -30,7 +30,7 @@ public void ResponseCodeIsConsideredTransient(HttpStatusCode code)
         public void ResponseCodeIsNotConsideredTransient(HttpStatusCode code)
         {
             var strategy = new HttpStatusCodeErrorDetectionStrategy();
-            Assert.False(strategy.IsTransient(new HttpRequestExceptionWithStatus { StatusCode = code }));
+            Assert.False(strategy.IsTransient(new HttpRequestWithStatusException { StatusCode = code }));
         }
 
         [Fact]

Microsoft.Rest/ClientRuntime.Tracing.Tests/ClientRuntime.Tracing.Tests.csproj

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
-<Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+<Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003" InitialTargets="TurnOffCodeAnalysis">
   <Import Project="..\..\packages\xunit.runner.visualstudio.0.99.9-build1021\build\net20\xunit.runner.visualstudio.props" Condition="Exists('..\..\packages\xunit.runner.visualstudio.0.99.9-build1021\build\net20\xunit.runner.visualstudio.props')" />
   <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
   <PropertyGroup>

Microsoft.Rest/ClientRuntime/BasicAuthenticationCredentials.cs

@@ -2,6 +2,7 @@
 // Licensed under the MIT License. See License.txt in the project root for license information.
 
 using System;
+using System.Globalization;
 using System.Net.Http;
 using System.Net.Http.Headers;
 using System.Text;
@@ -18,6 +19,8 @@ public class BasicAuthenticationCredentials : ServiceClientCredentials
         /// <summary>
         /// Basic auth username.
         /// </summary>
+        [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Naming", 
+            "CA1702:CompoundWordsShouldBeCasedCorrectly", MessageId = "Username")]
         public string Username { get; set; }
 
         /// <summary>
@@ -34,9 +37,15 @@ public class BasicAuthenticationCredentials : ServiceClientCredentials
         public override Task ProcessHttpRequestAsync(HttpRequestMessage request,
             CancellationToken cancellationToken)
         {
+            if (request == null)
+            {
+                throw new ArgumentNullException("request");
+            }
             // Add username and password to "Basic" header of each request.
             request.Headers.Authorization = new AuthenticationHeaderValue("Basic",
-                Convert.ToBase64String(Encoding.UTF8.GetBytes(string.Format("{0}:{1}",
+                Convert.ToBase64String(Encoding.UTF8.GetBytes(string.Format(
+                    CultureInfo.InvariantCulture, 
+                    "{0}:{1}",
                     Username,
                     Password).ToCharArray())));
             return PlatformTaskEx.FromResult(null);

Microsoft.Rest/ClientRuntime/ClientRuntime.csproj

@@ -39,6 +39,7 @@
   <Import Project="$(SolutionDir)\tools\AutoRest.Settings.targets" />
   <ItemGroup>
     <Compile Include="BasicAuthenticationCredentials.cs" />
+    <Compile Include="GlobalSuppressions.cs" />
     <Compile Include="HttpExtensions.cs" />
     <Compile Include="IDeserializationModel.cs" />
     <Compile Include="TypeConversion.cs" />

Microsoft.Rest/ClientRuntime/GlobalSuppressions.cs

@@ -0,0 +1,6 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License. See License.txt in the project root for license information.
+
+[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Design", "CA1021:AvoidOutParameters", MessageId = "2#", Scope = "member", Target = "Microsoft.Rest.TransientFaultHandling.ShouldRetryHandler.#Invoke(System.Int32,System.Exception,System.TimeSpan&)")]
+[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Design", "CA2210:AssembliesShouldHaveValidStrongNames", Justification="We do give it strong name and sign it when build in CI server and verify it")]
+

Microsoft.Rest/ClientRuntime/HttpExtensions.cs

@@ -58,7 +58,7 @@ public static HttpHeaders GetContentHeaders(this HttpRequestMessage request)
         /// <returns>The content headers.</returns>
         public static HttpHeaders GetContentHeaders(this HttpResponseMessage response)
         {
-            if (response.Content != null)
+            if (response != null && response.Content != null)
             {
                 return response.Content.Headers;
             }

Microsoft.Rest/ClientRuntime/HttpOperationException.cs

@@ -1,7 +1,6 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 
-using Microsoft.Rest.Properties;
 using System;
 using System.Net.Http;
 
@@ -10,6 +9,13 @@ namespace Microsoft.Rest
     /// <summary>
     /// Exception thrown for an invalid response with custom error information.
     /// </summary>
+    [System.Diagnostics.CodeAnalysis.SuppressMessage(
+        "Microsoft.Design", 
+        "CA1032:ImplementStandardExceptionConstructors"), 
+    System.Diagnostics.CodeAnalysis.SuppressMessage(
+        "Microsoft.Usage", 
+        "CA2237:MarkISerializableTypesWithSerializable", 
+        Justification = "All properties of this class get serialized manually")]
     public class HttpOperationException<T> : HttpRequestException
     {
         /// <summary>
@@ -27,6 +33,14 @@ public class HttpOperationException<T> : HttpRequestException
         /// </summary>
         public T Body { get; set; }
 
+        /// <summary>
+        /// Initializes a new instance of the HttpOperationException class.
+        /// </summary>
+        public HttpOperationException() 
+            : base()
+        {
+        }
+
         /// <summary>
         /// Initializes a new instance of the HttpOperationException class.
         /// </summary>

Microsoft.Rest/ClientRuntime/ILazyCollection.cs

@@ -6,6 +6,8 @@ namespace Microsoft.Rest
     /// <summary>
     /// Represents a collection that supports on-demand initialization.
     /// </summary>
+    [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Naming", 
+        "CA1711:IdentifiersShouldNotHaveIncorrectSuffix")]
     public interface ILazyCollection
     {
         /// <summary>

Microsoft.Rest/ClientRuntime/IServiceClientTracingInterceptor.cs

@@ -56,6 +56,10 @@ public interface IServiceClientTracingInterceptor
         /// </summary>
         /// <param name="invocationId">Method invocation identifier.</param>
         /// <param name="exception">The error.</param>
+        [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Naming", 
+            "CA1716:IdentifiersShouldNotMatchKeywords", 
+            MessageId = "Error",
+            Justification="The primary client applications will be C#")]
         void Error(string invocationId, Exception exception);
 
         /// <summary>
@@ -64,6 +68,10 @@ public interface IServiceClientTracingInterceptor
         /// </summary>
         /// <param name="invocationId">Method invocation identifier.</param>
         /// <param name="returnValue">Method return value.</param>
+        [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Naming", 
+            "CA1716:IdentifiersShouldNotMatchKeywords", 
+            MessageId = "Exit",
+            Justification="The primary client applications will be C#")]
         void Exit(string invocationId, object returnValue);
     }
 }

Microsoft.Rest/ClientRuntime/LazyList.cs

@@ -10,6 +10,8 @@ namespace Microsoft.Rest
     /// Represents an object list that supports on-demand initialization.
     /// </summary>
     /// <typeparam name="T"></typeparam>
+    [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Naming", 
+        "CA1710:IdentifiersShouldHaveCorrectSuffix")]
     public class LazyList<T> : IList<T>, ILazyCollection
     {
         private IList<T> _list;

Microsoft.Rest/ClientRuntime/PlatformTaskEx.cs

@@ -7,11 +7,11 @@
 
 namespace Microsoft.Rest
 {
-    public class PlatformTaskEx
+    [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Naming", 
+        "CA1711:IdentifiersShouldNotHaveIncorrectSuffix",
+        Justification="We think with Ex is better than using 2")]
+    public static class PlatformTaskEx
     {
-        //Per FxCop performance rule to prevent the compiler from generating a default constructor.
-        private PlatformTaskEx() { }
-
         public static Task FromResult(object result)
         {
 #if NET45
@@ -21,12 +21,12 @@ public static Task FromResult(object result)
 #endif
         }
 
-        public static Task Delay(TimeSpan delay)
+        public static Task Delay(TimeSpan delayTime)
         {
 #if NET45
-            return Task.Delay(delay);
+            return Task.Delay(delayTime);
 #else
-            return TaskEx.Delay(delay);
+            return TaskEx.Delay(delayTime);
 #endif
         }
 

Microsoft.Rest/ClientRuntime/Properties/AssemblyInfo.cs

@@ -2,8 +2,10 @@
 // Licensed under the MIT License. See License.txt in the project root for license information.
 
 
+using System;
 using System.Reflection;
 using System.Resources;
+using System.Runtime.InteropServices;
 
 [assembly: AssemblyTitle("Microsoft Rest Client Library")]
 [assembly: AssemblyDescription("Provides an HTTP pipeline for authentication, tracing, logging and transient fault handling.")]
@@ -18,3 +20,6 @@
 [assembly: AssemblyTrademark("")]
 [assembly: AssemblyCulture("")]
 [assembly: NeutralResourcesLanguage("en")]
+
+[assembly: ComVisible(false)]
+[assembly: CLSCompliant(false)]

Microsoft.Rest/ClientRuntime/Properties/Resources.resx

@@ -141,6 +141,9 @@
   <data name="ExceptionRetryManagerNotSet" xml:space="preserve">
     <value>The default RetryManager has not been set. Set it by invoking the RetryManager.SetDefault static method, or if you are using declarative configuration, you can invoke the RetryPolicyFactory.CreateDefault() method to automatically create the retry manager from the configuration file.</value>
   </data>
+  <data name="ITransientErrorDetectionStrategyNotImplemented" xml:space="preserve">
+    <value>The error detection strategy type must implement the ITransientErrorDetectionStrategy interface.</value>
+  </data>
   <data name="ResponseStatusCodeError" xml:space="preserve">
     <value>Response status code indicates server error: {0} ({1}).</value>
   </data>

Microsoft.Rest/ClientRuntime/RetryDelegatingHandler.cs

@@ -98,7 +98,7 @@ await RetryPolicy.ExecuteAsync(async () =>
 
                         if (!responseMessage.IsSuccessStatusCode)
                         {
-                            throw new HttpRequestExceptionWithStatus(string.Format(
+                            throw new HttpRequestWithStatusException(string.Format(
                                 CultureInfo.InvariantCulture,
                                 Resources.ResponseStatusCodeError,
                                 (int)responseMessage.StatusCode,