Linter Validation rules

src/core/AutoRest.Core/Properties/Resources.resx

@@ -195,6 +195,41 @@
   <data name="MsdnReferencesDiscouraged" xml:space="preserve">
     <value>For better generated code quality, remove all references to "msdn.microsoft.com".</value>
   </data>
+  <data name="APIVersionFormatIsNotValid" xml:space="preserve">
+    <value>API Version must be in the format: yyyy-MM-dd, optionally followed by -preview, -alpha, -beta, -rc, -privatepreview.</value>
+  </data>
+  <data name="HttpVerbIsNotValid" xml:space="preserve">
+    <value>Permissible values for HTTP Verb are delete,get,put,patch,head,options,post. </value>
+  </data>
+  <data name="ResourceModelIsNotValid" xml:space="preserve">
+    <value>The id, name, type, location and tags properties of the Resource must be present with id, name and type as read-only</value>
+  </data>
+  <data name="ResourceIsMsResourceNotValid" xml:space="preserve">
+    <value>A 'Resource' definition must have x-ms-azure-resource extension enabled and set to true.</value>
+  </data>
+  <data name="XmsClientNameInValid" xml:space="preserve">
+    <value>Value of 'x-ms-client-name' cannot be the same as the property/model name.</value>
+  </data>
+  <data name="DeleteMustHaveEmptyBody" xml:space="preserve">
+    <value>'Delete' operation cannot have parameters in body.</value>
+  </data>
+  <data name="SkuModelIsNotValid" xml:space="preserve">
+    <value>Sku Model is not valid. A Sku model must have name property. It can also have tier, size, family, capacity as optional properties.</value>
+  </data>
+  <data name="PutGetPatchResponseInvalid" xml:space="preserve">
+    <value>{0} has different responses for PUT/GET/PATCH operations. The PUT/GET/PATCH operations must have same schema response.</value>
+  </data>
+  <data name="OperationsAPINotImplemented" xml:space="preserve">
+    <value>Operations API must be implemented for the service.</value>
+  </data>
+  <data name="TrackedResourceIsNotValid" xml:space="preserve">
+    <value>Tracked Resource failing validation is: {0}. Validation Failed: {1}. 
+    A Tracked Resource must have: 
+    1. A Get Operation 
+    2. A ListByResourceGroup operation with x-ms-pageable extension and 
+    3. A ListBySubscriptionId operation with x-ms-pageable extension.
+    4. Type, Location, Tags should not be used in the properties.</value>
+  </data>
   <data name="BodyMustHaveSchema" xml:space="preserve">
     <value>Each body parameter must have a schema</value>
   </data>
@@ -273,6 +308,9 @@
   <data name="PathCannotBeNullOrEmpty" xml:space="preserve">
     <value>path cannot be null or an empty string or a string with white spaces while getting the parent directory</value>
   </data>
+  <data name="GuidUsageNotValid" xml:space="preserve">
+    <value>Guid used at the #/Definitions/{1}/.../{0}. Usage of Guid is not recommanded</value>
+  </data>
   <data name="OperationNameNotValid" xml:space="preserve">
     <value>'GET' operation must use method name 'Get' or Method name start with 'List', 'PUT' operation must use method name 'Create', 'PATCH' operation must use method name 'Update' and 'DELETE' operation must use method name 'Delete'.</value>
   </data>

src/modeler/AutoRest.Swagger/Model/Info.cs

@@ -39,6 +39,7 @@ public string Description
 
         public License License { get; set; }
 
+        [Rule(typeof(APIVersionPattern))]
         public string Version { get; set; }
 
         [JsonProperty("x-ms-code-generation-settings")]

src/modeler/AutoRest.Swagger/Model/Schema.cs

@@ -36,6 +36,7 @@ public class Schema : SwaggerObject
         /// Key is a type serviceTypeName.
         /// </summary>
         [CollectionRule(typeof(AvoidNestedProperties))]
+        [Rule(typeof(XmsClientNameValidation))]
         public Dictionary<string, Schema> Properties { get; set; }
 
         public bool ReadOnly { get; set; }
@@ -222,7 +223,7 @@ private void CompareProperties(ComparisonContext context, Schema priorSchema)
             }
         }
 
-        private static Schema FindReferencedSchema(string reference, IDictionary<string, Schema> definitions)
+        public static Schema FindReferencedSchema(string reference, IDictionary<string, Schema> definitions)
         {
             if (reference != null && reference.StartsWith("#", StringComparison.Ordinal))
             {

src/modeler/AutoRest.Swagger/Model/ServiceDefinition.cs

@@ -79,6 +79,10 @@ public ServiceDefinition()
         /// Key is actual path and the value is serializationProperty of http operations and operation objects.
         /// </summary>
         [Rule(typeof(UniqueResourcePaths))]
+        [Rule(typeof(PutGetPatchResponseValidation))]
+        [Rule(typeof(OperationsAPIImplementationValidation))]
+        [CollectionRule(typeof(HttpVerbValidation))]
+        [CollectionRule(typeof(DeleteMustHaveEmptyBody))]
         public Dictionary<string, Dictionary<string, Operation>> Paths { get; set; }
 
         /// <summary>
@@ -91,6 +95,11 @@ public ServiceDefinition()
         /// <summary>
         /// Key is the object serviceTypeName and the value is swagger definition.
         /// </summary>
+        [Rule(typeof(ResourceModelValidation))]
+        [Rule(typeof(TrackedResourceValidation))]
+        [Rule(typeof(ResourceIsMsResourceValidation))]
+        [Rule(typeof(GuidValidation))]
+        [Rule(typeof(SkuModelValidation))]
         public Dictionary<string, Schema> Definitions { get; set; }
 
         /// <summary>

src/modeler/AutoRest.Swagger/Model/SwaggerParameter.cs

@@ -16,6 +16,7 @@ namespace AutoRest.Swagger.Model
     /// </summary>
     [Serializable]
     [Rule(typeof(ParameterDescriptionRequired))]
+    [Rule(typeof(XmsClientNameParameterValidation))]
     public class SwaggerParameter : SwaggerObject
     {
         private bool _isRequired;

src/modeler/AutoRest.Swagger/Validation/APIVersionPattern.cs

@@ -0,0 +1,41 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License. See License.txt in the project root for license information.
+
+using AutoRest.Core.Logging;
+using AutoRest.Core.Properties;
+using AutoRest.Core.Validation;
+using System.Text.RegularExpressions;
+
+namespace AutoRest.Swagger.Validation
+{
+    /// <summary>
+    /// Validates the version of the swagger. API version must follow the date pattern
+    /// yyyy-MM-dd and allowed prefixes are -preview, -alpha, -beta, -rc, -privatepreview.
+    /// </summary>
+    public class APIVersionPattern : TypedRule<string>
+    {
+        private static readonly Regex VersionRegex = new Regex(@"^(20\d{2})-(0[1-9]|1[0-2])-((0[1-9])|[12][0-9]|3[01])(-(preview|alpha|beta|rc|privatepreview))?$");
+
+        /// <summary>
+        /// The template message for this Rule. 
+        /// </summary>
+        /// <remarks>
+        /// This may contain placeholders '{0}' for parameterized messages.
+        /// </remarks>
+        public override string MessageTemplate => Resources.APIVersionFormatIsNotValid;
+
+        /// <summary>
+        /// The severity of this message (ie, debug/info/warning/error/fatal, etc)
+        /// </summary>
+        public override Category Severity => Category.Warning;
+
+        /// <summary>
+        /// An <paramref name="version"/> fails this rule if it does not have the required format.
+        /// </summary>
+        /// <param name="version">Version to validate</param>
+        /// <returns>true if the version is valid. false otherwise.</returns>
+        public override bool IsValid(string version) => !string.IsNullOrEmpty(version) && VersionRegex.IsMatch(version);
+    }
+
+
+}