-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{AKS} Fix role assignment failure caused by the breaking change of default API version bump of the auth SDK #6203
Merged
zhoxing-ms
merged 7 commits into
Azure:main
from
FumingZhang:fuming/fix-podidentity-0413
Apr 14, 2023
Merged
{AKS} Fix role assignment failure caused by the breaking change of default API version bump of the auth SDK #6203
zhoxing-ms
merged 7 commits into
Azure:main
from
FumingZhang:fuming/fix-podidentity-0413
Apr 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @FumingZhang, |
ghost
requested a review
from zhoxing-ms
April 13, 2023 08:15
AKS |
ghost
requested a review
from yanzhudd
April 13, 2023 08:15
ghost
assigned zhoxing-ms
Apr 13, 2023
ghost
requested a review
from yonzhan
April 13, 2023 08:15
ghost
added
the
AKS
label
Apr 13, 2023
Queued a live test pipeline to validate the change, test passed! |
karataliu
approved these changes
Apr 13, 2023
zhoxing-ms
reviewed
Apr 14, 2023
Co-authored-by: Xing Zhou <[email protected]>
zhoxing-ms
approved these changes
Apr 14, 2023
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=47908&view=results |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks pod-identity
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.