Change generated.py files to commands.py #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have actually made this change in #1059 but I'm fine with this PR going in then I can resolve conflicts. |
|
It might mean I have less conflicts to deal with later :) |
|
@derekbekoe any issues with me merging this? |
|
LGTM |
|
Other open PRs may have to be rebased before merging though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has confused almost every person who has attempted to onboard new commands. Everyone assumes that the
generated.pyfile is... well... generated, which is not the case. This updates the file names, references and help doc to make this clear.