web: initial slot end to end support #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@derekbekoe @mayurid, this is low risk, and webapp specific change. Would you review it and consider included in the upcoming release? |
derekbekoe
reviewed
Nov 14, 2016
| @@ -72,6 +72,56 @@ | |||
| short-summary: commands to configure hostnames | |||
| """ | |||
|
|
|||
| helps['appservice web log'] = """ | |||
| type: group | |||
| short-summary: commands to manager logs | |||
| register_cli_argument('appservice web deployment slot', 'disable', help='disable auto swap', action='store_true') | ||
| register_cli_argument('appservice web deployment slot', 'target_slot', help="target slot to swap, default to 'production'") |
There was a problem hiding this comment.
Can we not use default='production' here?
There was a problem hiding this comment.
production is not yet documented literal, so i would like avoid the usage at cli
derekbekoe
approved these changes
Nov 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure supports from create, link to git, swap, to deploy. Those are still the minimum, but enough to get basic functions. This will get #1255 resolved.
In the next period, we should consider to
slot deleteto support auto delete site, etc