{Role} Bump role_definitions API version to 2022-05-01-preview
#26577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
ghost
requested a review
from 
|
Role |
ghost
added
|
This needs to be solved by #26475. A temporary workaround is to remove |
|
|
@yanzhudd will help take a look at this test issue~ |
Hi @jiasli if self.is_live:
time.sleep(30) |
|
#27222 introduces merge conflicts and makes recordings for |
jiasli
force-pushed
the
role_definitions
branch
from
f99363b to
f8c5501
Compare
jiasli
commented
Aug 24, 2023
| @@ -5993,6 +5993,7 @@ def test_create_image_version_with_region_cvm_encryption(self, resource_group, r | |||
| self.cmd('sig image-version delete -g {rg} --gallery-name {gallery} --gallery-image-definition {image} --gallery-image-version {version}') | |||
| time.sleep(60) # service end latency | |||
| self.cmd('sig image-definition delete -g {rg} --gallery-name {gallery} --gallery-image-definition {image}') | |||
| time.sleep(60) | |||
There was a problem hiding this comment.
An extra sleep is added to fix #26577 (comment) according to #26577 (comment).
time.sleep is patched during playback mode, so there is no need to add if self.is_live: check:
jiasli
commented
Aug 24, 2023
| @@ -256,7 +256,7 @@ def test_role_definition_scenario(self): | |||
| class RoleAssignmentScenarioTest(RoleScenarioTestBase): | |||
|
|
|||
| def __init__(self, *arg, **kwargs): | |||
| super().__init__(*arg, random_config_dir=True, **kwargs) | |||
| super().__init__(*arg, **kwargs) | |||
There was a problem hiding this comment.
random_config_dir=True needs to be removed according to #26577 (comment)
@bebound, should I revert it? If not, playback test may fail. If yes, live test will certainly fail, so other team member can't live run role module's tests.
I can also temporarily disable test_role_assignment_handle_conflicted_assignments to eliminate the root cause which writes to config file.
There was a problem hiding this comment.
My preferred solution is to merge #26475.
This is a good chance to test it works. It only affect test, even if it contains bugs, it will not affect user.
jiasli
requested review from
zhoxing-ms,
jsntcy,
wangzelin007,
yanzhudd and
evelyn-ys
as code owners
jiasli
requested review from
calvinhzy,
digimaun,
andyliuliming,
kairu-ms and
necusjz
as code owners
jiasli
commented
Aug 24, 2023
|
|
||
| @ResourceGroupPreparer(name_prefix='cli_role_assign') | ||
| @AllowLargeResponse() | ||
| def test_role_assignment_handle_conflicted_assignments(self, resource_group): |
There was a problem hiding this comment.
test_role_assignment_handle_conflicted_assignments is the only test that writes to config file. I moved it to a dedicated RoleAssignmentWithConfigScenarioTest so that other tests in RoleAssignmentScenarioTest won't need random_config_dir.
bebound
approved these changes
Aug 29, 2023
yanzhudd
approved these changes
Aug 29, 2023
evelyn-ys
approved these changes
Aug 29, 2023
zhoxing-ms
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az roleDescription
Close #26429
Bump
role_definitionsAPI version to 2022-05-01-preview