Update _profile.py to allow azure-devops plugins to use user assigned managed identities #26776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @JayDoubleu, |
❌AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
ghost
added
the
customer-reported
|
Thank you for your contribution JayDoubleu! We will review the pull request and get back to you soon. |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
JayDoubleu
changed the title
yonzhan
modified the milestones:
September 2023 (2023-09-26),
October 2023 (2023-11-15)❗ Breaking change release ❗
yonzhan
modified the milestones:
October 2023 (2023-11-14)❗ Breaking change release ❗,
Backlog
jiasli
reviewed
Aug 27, 2024
| @@ -365,7 +365,7 @@ def get_raw_token(self, resource=None, scopes=None, subscription=None, tenant=No | |||
| if identity_type: | |||
| # managed identity | |||
| if tenant: | |||
| raise CLIError("Tenant shouldn't be specified for managed identity account") | |||
| tenant = False | |||
There was a problem hiding this comment.
See #26775 (comment)
Silently discarding tenant for managed identity may lead to unexpected and misleading behaviors.
There was a problem hiding this comment.
Great feedback, I don't have time to look into strategic solution for this but the fundamental functionality of managed identities for artifacts is broken because of this so I'm not sure who/if there's someone to look at it ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #26775