-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{Packaging} Install pip in Homebrew virtual env #27186
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Packaging |
@@ -126,6 +126,11 @@ def update_formula() -> str: | |||
upstream_sha = compute_sha256(HOMEBREW_UPSTREAM_URL) | |||
text = re.sub('sha256 ".*"', 'sha256 "{}"'.format(upstream_sha), text, 1) | |||
text = re.sub('.*revision.*\n', '', text, 1) # remove revision for previous version if exists | |||
|
|||
# include pip when creating venv, see https://github.com/Azure/azure-cli/issues/27047 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It the link incorrect? #27047 doesn't seem to be related to pip
in a venv.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update to homebrew pr link: Homebrew/brew#15792
|
||
# include pip when creating venv, see https://github.com/Homebrew/brew/pull/15792 | ||
# this can be removed after Homebrew merges our PR | ||
text = re.sub('system_site_packages: false', 'system_site_packages: false, without_pip: false', text, 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As formula_generate.py
always updates the formula on Homebrew side, it requires a weird process that we always need 2 separate PRs:
- one to make the change,
- once the change is merged to Homebrew side's formula, one without the change
An alternative I can think of is to directly submit a PR to https://github.com/Homebrew/homebrew-core/blob/master/Formula/a/azure-cli.rb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to manually fix here as Homebrew pipeline is broken now.
Creating PR to homebrew is more convenient.
Homebrew/brew#15792 (comment) made a very good point.
|
Description
Homebrew does not install pip when create venv in Homebrew/brew#15792, adding
without_pip: false
to install pip.pip
also installssetuptools
, which is also required in namespace package:PS: In general, we can make this change in homebrew repo.
The homebrew formula is broken for now, and we're using the 2.50 formula. I have to make the change here.
Related issue:
setuptools
to dependency #27196Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a
: Make some customer-facing breaking change[Component Name 2]
az command b
: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.