{Packaging} Add pip to dependency
#29922
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
Hi @bebound, |
️✔️AzureCLI-BreakingChangeTest
|
|
Packaging |
microsoft-github-policy-service
bot
requested review from
jiasli,
wangzelin007,
yonzhan and
jsntcy
bebound
commented
Sep 18, 2024
| @@ -58,6 +58,7 @@ | |||
| 'msrestazure~=0.6.4', | |||
| 'packaging>=20.9', | |||
| 'paramiko>=2.0.8,<4.0.0', | |||
| 'pip', # Homebrew does not install pip in venv, `az extension add` needs it | |||
There was a problem hiding this comment.
extension module is implemented in core, so I add it to azure-cli-core.
bebound
requested review from
evelyn-ys,
kairu-ms,
zhoxing-ms,
calvinhzy and
necusjz
as code owners
This was referenced Oct 18, 2024
6 tasks
|
This PR is only for Homebrew. In other distros, However, brew calls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Homebrew stops install
pipin Python 3.12 venv(Homebrew/brew#16306), which is needed inaz extension add.Ref: https://github.com/orgs/Homebrew/discussions/5600