Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] remove k8s default version from CLI #5456

Merged
merged 3 commits into from
Feb 3, 2018

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented Feb 2, 2018

This allows the RP to set the default version if the user doesn't supply one explicitly. Currently that's Kubernetes 1.7.9, but should bump up to 1.7.12 soon.

Setting the default on the server lets us to stop updating the CLI just to chase newer versions.


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

Command Guidelines

  • Each command and parameter has a meaningful description.
  • Each new command has a test.

(see Authoring Command Modules)

This allows the RP to set the default version if the user doesn't
supply one explicitly.
@promptws
Copy link

promptws commented Feb 2, 2018

View a preview at https://prompt.ws/r/Azure/azure-cli/5456
This is an experimental preview for @microsoft users.

@brendandburns
Copy link
Member

LGTM.

@tjprescott tjprescott added the ACS az acs/aks/openshift label Feb 3, 2018
@tjprescott tjprescott merged commit 2e8d142 into Azure:dev Feb 3, 2018
@mboersma mboersma deleted the server-sets-default-k8s branch February 3, 2018 00:47
LukaszStem pushed a commit to LukaszStem/azure-cli that referenced this pull request Feb 21, 2018
* [AKS] remove k8s default version from CLI

This allows the RP to set the default version if the user doesn't
supply one explicitly.

* Update HISTORY.rst for new `az aks create` default version behavior

* Fix some errant indentation.
@haroldrandom haroldrandom added the ACS az acs/aks/openshift label Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACS az acs/aks/openshift
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants