Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] fix az aks browse if dashboard isn't prefixed by "pods/" #5462

Merged
merged 2 commits into from
Feb 2, 2018

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented Feb 2, 2018

Makes finding the k8s dashboard pod more robust by returning the last string segment following a / character, if there is one.

Closes Azure/AKS#159

@promptws
Copy link

promptws commented Feb 2, 2018

View a preview at https://prompt.ws/r/Azure/azure-cli/5462
This is an experimental preview for @microsoft users.

Copy link
Member

@derekbekoe derekbekoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add to release notes in HISTORY.rst?

@mboersma
Copy link
Member Author

mboersma commented Feb 2, 2018

Add to release notes in HISTORY.rst?

@derekbekoe, done. (This is just a bug fix for an edge case, so I wasn't sure if it needed to go into the changelog.)

@derekbekoe derekbekoe merged commit fb460aa into Azure:dev Feb 2, 2018
@mboersma mboersma deleted the fix-aks-browse branch February 3, 2018 00:47
LukaszStem pushed a commit to LukaszStem/azure-cli that referenced this pull request Feb 21, 2018
…re#5462)

* [AKS] fix `az aks browse` if dashboard isn't prefixed by "pods/"

* Update HISTORY.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants