Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed query responses to return null Content if it is a failure. #1036

Merged
merged 6 commits into from
Nov 21, 2019
Merged

Fixed query responses to return null Content if it is a failure. #1036

merged 6 commits into from
Nov 21, 2019

Conversation

j82w
Copy link
Contributor

@j82w j82w commented Nov 20, 2019 •
edited
Loading

Pull Request Template

Description

This fixes a bug where query stream iterator response message would return a stream on failure scenario. It now returns null for the content if the query failed.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Closing issues

closes #1034

@j82w j82w added the QUERY label Nov 20, 2019
@j82w j82w self-assigned this Nov 20, 2019
@j82w j82w changed the title Fixed QueryResponse to always return Content as null if it is a failure. Fixed query responses to return null Content if it is a failure. Nov 20, 2019
kirankumarkolli
kirankumarkolli approved these changes Nov 21, 2019
View reviewed changes
Copy link
Member

@kirankumarkolli kirankumarkolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@j82w j82w requested a review from sboshra November 21, 2019 21:09
@j82w j82w merged commit 3bcab2e into master Nov 21, 2019
@j82w j82w deleted the users/jawilley/query/stream_on_error branch November 21, 2019 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirankumarkolli kirankumarkolli kirankumarkolli approved these changes

@bchong95 bchong95 bchong95 approved these changes

@sboshra sboshra Awaiting requested review from sboshra sboshra is a code owner

Assignees

@j82w j82w

Labels
QUERY
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FeedIterator.ReadNextAsync() returns ErrorMessage with expired resourceToken
3 participants
@j82w @bchong95 @kirankumarkolli